Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate redundant split_string_to_array, split_string_on & split_path methods #465

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Apr 5, 2024

Description

  • All three methods performed nearly identical operations, but were defined in anonymous namespaces and not exposed in a header preventing sharing.
  • Consolidate all three into a new split_string_to_vector in string_utils.hpp

closes #454

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested review from a team as code owners April 5, 2024 17:37
@dagardner-nv dagardner-nv self-assigned this Apr 5, 2024
@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change labels Apr 5, 2024
ci/iwyu/mappings.imp Show resolved Hide resolved
Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Merging #465 (44af2e8) into branch-24.06 (5a6ae3c) will decrease coverage by 0.02%.
Report is 1 commits behind head on branch-24.06.
The diff coverage is 63.63%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-24.06     #465      +/-   ##
================================================
- Coverage         73.82%   73.80%   -0.02%     
================================================
  Files               402      403       +1     
  Lines             14402    14398       -4     
  Branches           1130     1128       -2     
================================================
- Hits              10632    10627       -5     
- Misses             3770     3771       +1     
Flag Coverage Δ
cpp 69.15% <63.63%> (-1.27%) ⬇️
py 41.86% <63.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
cpp/mrc/src/internal/utils/parse_ints.cpp 94.11% <100.00%> (-1.72%) ⬇️
cpp/mrc/src/public/utils/string_utils.cpp 100.00% <100.00%> (ø)
...mrc/_pymrc/include/pymrc/utilities/json_values.hpp 85.71% <ø> (ø)
python/mrc/_pymrc/src/utilities/json_values.cpp 93.39% <100.00%> (-0.13%) ⬇️
cpp/mrc/src/internal/utils/parse_config.cpp 0.00% <0.00%> (ø)

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a6ae3c...44af2e8. Read the comment docs.

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0701b13 into nv-morpheus:branch-24.06 Apr 10, 2024
18 checks passed
@dagardner-nv dagardner-nv deleted the david-split-string-454 branch April 10, 2024 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Consolidate duplicate split_string_on and split_string_to_array methods
2 participants