Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arm64 builds to CI #524

Merged
merged 34 commits into from
Jan 15, 2025
Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 19, 2024

Description

Related to nv-morpheus/utilities#90
Closes #525

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added improvement Improvement to existing functionality non-breaking Non-breaking change DO NOT MERGE labels Dec 19, 2024
@dagardner-nv dagardner-nv self-assigned this Dec 19, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner December 19, 2024 20:01
@dagardner-nv dagardner-nv marked this pull request as draft December 19, 2024 21:40
@dagardner-nv dagardner-nv marked this pull request as ready for review December 21, 2024 00:37
@dagardner-nv dagardner-nv requested a review from a team as a code owner December 21, 2024 00:37
@dagardner-nv dagardner-nv added the conda-build Enables running the conda-build step on a PR label Dec 30, 2024
Copy link
Member

@willkill07 willkill07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. I believe the conflicts are for the copyright year.

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 5f9cc13 into nv-morpheus:branch-25.02 Jan 15, 2025
22 checks passed
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.18%. Comparing base (7d5e48f) to head (d992392).
Report is 2 commits behind head on branch-25.02.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##           branch-25.02     #524       +/-   ##
=================================================
+ Coverage         54.34%   74.18%   +19.83%     
=================================================
  Files               372      407       +35     
  Lines             12553    15053     +2500     
  Branches           1104     1191       +87     
=================================================
+ Hits               6822    11167     +4345     
+ Misses             5731     3886     -1845     
Flag Coverage Δ
cpp 70.73% <100.00%> (+22.91%) ⬆️
py 44.24% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/src/internal/system/engine_factory_cpu_sets.cpp 91.91% <100.00%> (+37.18%) ⬆️

... and 165 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d5e48f...d992392. Read the comment docs.

rapids-bot bot pushed a commit to nv-morpheus/Morpheus that referenced this pull request Jan 16, 2025
* Add Arm64 build and test stages to CI
* Refactor CI docker images as a multi-arch container
* Add Arm64 Conda package output
* Add Arm64 (`aarch64`) to `dependencies.yaml` matrix
* Skip DOCA builds for arm (#2092).
* Skip tests for ARM conda builds, this avoids the need for an ARM GPU runner.
* The following packages are x86_64 specific: include-what-you-use (later versions support ARM), vale, milvus and pymilvus.
* The following packages have arm builds on pypi but not on conda-forge: pypdfium2, newspaper3k (package is no-arch but some deps are x86_64 only). For these we obtain them via pip on arm, but continue to install via conda for x86_64.
* pytorch cuda builds exist for ARM but lack the same meta-data that the x86_64 builds do. For now the cpu version of torch is installed for ARM #2095 

Related to nv-morpheus/utilities#90
Requires nv-morpheus/MRC#524 to be merged first
Closes [#2094](#2094)

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #2093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda-build Enables running the conda-build step on a PR improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: TestPipeline.EngineFactories fails on arm64
3 participants