-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Arm64 builds to CI #524
Add Arm64 builds to CI #524
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM. I believe the conflicts are for the copyright year.
/merge |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-25.02 #524 +/- ##
=================================================
+ Coverage 54.34% 74.18% +19.83%
=================================================
Files 372 407 +35
Lines 12553 15053 +2500
Branches 1104 1191 +87
=================================================
+ Hits 6822 11167 +4345
+ Misses 5731 3886 -1845
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 165 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
* Add Arm64 build and test stages to CI * Refactor CI docker images as a multi-arch container * Add Arm64 Conda package output * Add Arm64 (`aarch64`) to `dependencies.yaml` matrix * Skip DOCA builds for arm (#2092). * Skip tests for ARM conda builds, this avoids the need for an ARM GPU runner. * The following packages are x86_64 specific: include-what-you-use (later versions support ARM), vale, milvus and pymilvus. * The following packages have arm builds on pypi but not on conda-forge: pypdfium2, newspaper3k (package is no-arch but some deps are x86_64 only). For these we obtain them via pip on arm, but continue to install via conda for x86_64. * pytorch cuda builds exist for ARM but lack the same meta-data that the x86_64 builds do. For now the cpu version of torch is installed for ARM #2095 Related to nv-morpheus/utilities#90 Requires nv-morpheus/MRC#524 to be merged first Closes [#2094](#2094) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #2093
Description
Dockerfile
as a multi-arch containeraarch64
) todependencies.yaml
matrixRelated to nv-morpheus/utilities#90
Closes #525
Checklist