Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Fix IoScheduler::yield_until and improve tests #533

Conversation

willkill07
Copy link
Member

@willkill07 willkill07 commented Jan 30, 2025

Description

This PR simplifies the implementation of yield_for and yield_until while also eliminating a bug in yield_for which can cause it to prematurely notify.

Closes #532

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@willkill07 willkill07 requested a review from a team as a code owner January 30, 2025 19:10
@willkill07 willkill07 added bug Something isn't working non-breaking Non-breaking change labels Jan 30, 2025
@willkill07 willkill07 changed the title Bugfix: improve test for Concurrent IOScheduler Bugfix: Fix IoScheduler::wait_for and improve tests Jan 30, 2025
@willkill07 willkill07 changed the title Bugfix: Fix IoScheduler::wait_for and improve tests Bugfix: Fix IoScheduler::wait_until and improve tests Jan 30, 2025
@willkill07 willkill07 changed the title Bugfix: Fix IoScheduler::wait_until and improve tests Bugfix: Fix IoScheduler::yield_until and improve tests Jan 30, 2025
@dagardner-nv dagardner-nv added this to the 25.02 - Release milestone Jan 30, 2025
Signed-off-by: Will Killian <wkillian@nvidia.com>
@willkill07 willkill07 force-pushed the will-bugfix-ioscheduler-wait_for-wait_until branch from c2bc35b to 5ad7e3d Compare January 30, 2025 19:16
@willkill07
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit b889adc into nv-morpheus:branch-25.02 Jan 30, 2025
20 of 21 checks passed
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.00%. Comparing base (22409a5) to head (5ad7e3d).
Report is 1 commits behind head on branch-25.02.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-25.02     #533      +/-   ##
================================================
- Coverage         74.03%   74.00%   -0.04%     
================================================
  Files               407      407              
  Lines             15103    15103              
  Branches           1198     1198              
================================================
- Hits              11182    11177       -5     
- Misses             3921     3926       +5     
Flag Coverage Δ
cpp 70.65% <ø> (-0.04%) ⬇️
py 44.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cpp/mrc/src/public/coroutines/io_scheduler.cpp 65.19% <ø> (ø)

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22409a5...5ad7e3d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants