Skip to content

Commit

Permalink
Fix missing dependency in DFP Grafana example (#1977)
Browse files Browse the repository at this point in the history
- Dependencies for DFP container were recently moved from `examples/digital_fingerprinting/production/conda_env.yaml`  to `conda/environments/examples_cuda-125_arch-x86_64.yaml` but `python-logging-loki` was not included.
- Add `python-logging-loki` to `example-dfp-prod` in `dependencies.yaml`.
- Remove `conda_env.yaml` since it's no longer being used anywhere.

Closes #1917

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

URL: #1977
  • Loading branch information
efajardo-nv authored Oct 28, 2024
1 parent 567e270 commit 036d0b4
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 37 deletions.
1 change: 1 addition & 0 deletions conda/environments/all_cuda-125_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,7 @@ dependencies:
- nemollm==0.3.5
- pymilvus==2.3.6
- pytest-kafka==0.6.0
- python-logging-loki
- sentence-transformers==2.7
- torch==2.4.0+cu124
name: all_cuda-125_arch-x86_64
1 change: 1 addition & 0 deletions conda/environments/examples_cuda-125_arch-x86_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ dependencies:
- milvus==2.3.5
- nemollm==0.3.5
- pymilvus==2.3.6
- python-logging-loki
- sentence-transformers==2.7
- torch==2.4.0+cu124
name: examples_cuda-125_arch-x86_64
3 changes: 3 additions & 0 deletions dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,9 @@ dependencies:
- kfp
- papermill=2.4.0
- s3fs
- pip
- pip:
- python-logging-loki

example-gnn:
common:
Expand Down
37 changes: 0 additions & 37 deletions examples/digital_fingerprinting/production/conda_env.yml

This file was deleted.

0 comments on commit 036d0b4

Please sign in to comment.