Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC]: Bind the provided abp-pcap-xgb directory to the docker container model repo at /models. #1201

Closed
2 tasks done
nyck33 opened this issue Sep 19, 2023 · 2 comments · Fixed by #1205
Closed
2 tasks done

[DOC]: Bind the provided abp-pcap-xgb directory to the docker container model repo at /models. #1201

nyck33 opened this issue Sep 19, 2023 · 2 comments · Fixed by #1205
Assignees
@efajardo-nv
Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team

Comments

@nyck33
Copy link

nyck33 commented Sep 19, 2023

How would you describe the priority of this documentation request

Medium

Please provide a link or source to the relevant docs

https://github.com/nv-morpheus/Morpheus/blob/branch-23.11/examples/abp_pcap_detection/README.md

Describe the problems in the documentation

I'm not sure what that means, I see the abp-pcap-xgb directory but not a docker container model repo at /models.

(Optional) Propose a correction

Please try to be a bit more clear.

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open documentation issues and have found no duplicates for this bug report
@nyck33 nyck33 added the doc Improvements or additions to documentation label Sep 19, 2023
@jarmak-nv jarmak-nv added Needs Triage Need team to review and classify external This issue was filed by someone outside of the Morpheus team labels Sep 19, 2023
@jarmak-nv
Copy link
Contributor

Hi @nyck33!

Thanks for submitting this issue - our team has been notified and we'll get back to you as soon as we can!
In the mean time, feel free to add any relevant information to this issue.

@efajardo-nv
Copy link
Contributor

@nyck33 it's referring to -v $PWD/abp-pcap-xgb:/models/abp-pcap-xgb in the docker run command which will mount the abp-pcap-xgb directory to /models/abp-pcap-xgb in the Triton container. The /models directory in the Triton container acts as the model repository from which models are loaded. We can reword that to make it more clear. Thanks.

@efajardo-nv efajardo-nv self-assigned this Sep 19, 2023
@efajardo-nv efajardo-nv moved this from Todo to In Progress in Morpheus Boards Sep 19, 2023
@efajardo-nv efajardo-nv mentioned this issue Sep 19, 2023
Merged
@jarmak-nv jarmak-nv moved this from In Progress to Review - Ready for Review in Morpheus Boards Sep 19, 2023
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Sep 22, 2023
rapids-bot bot pushed a commit that referenced this issue Sep 25, 2023
@efajardo-nv
ABP PCAP detection readme update (#1205)
969954c 
+ Add more detail to Triton server setup instructions

Closes #1201

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Eli Fajardo (https://github.com/efajardo-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #1205
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efajardo-nv efajardo-nv

Labels
doc Improvements or additions to documentation external This issue was filed by someone outside of the Morpheus team
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ABP PCAP detection readme update efajardo-nv/Morpheus
3 participants
@nyck33 @efajardo-nv @jarmak-nv