Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: DFP Azure output path/filename is hardcoded #1287

Closed
2 tasks done
pthalasta opened this issue Oct 18, 2023 · 1 comment · Fixed by #1290
Closed
2 tasks done

[BUG]: DFP Azure output path/filename is hardcoded #1287

pthalasta opened this issue Oct 18, 2023 · 1 comment · Fixed by #1290
Assignees
@drobison00
Labels
bug Something isn't working

Comments

@pthalasta
Copy link
Contributor

Version

23.11

Which installation method(s) does this occur on?

Source

Describe the bug.

DFP Azure pipeline currently has hardcoded value for output and doesn't have an option to customize the path when invoking with python. This needs to be considered as an input parameter with default path to allow customization on where the output is written and the format of the file

Minimum reproducible example

No response

Relevant log output

Click here to see error details
[Paste the error here, it will be hidden by default]

Full env printout

Click here to see environment details
[Paste the results of print_env.sh here, it will be hidden by default]

Other/Misc.

No response

Code of Conduct

  • I agree to follow Morpheus' Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
@pthalasta pthalasta added the bug Something isn't working label Oct 18, 2023
@mdemoret-nv
Copy link
Contributor

The property filename for the WriteToFileStage needs to come from a click option.

@drobison00 drobison00 mentioned this issue Oct 18, 2023
Merged
@jarmak-nv jarmak-nv moved this from Todo to Review - Ready for Review in Morpheus Boards Oct 18, 2023
rapids-bot bot pushed a commit that referenced this issue Oct 19, 2023
@drobison00
Make dfp_azure_pipeline inference output file configurable. (#1290)
ec6f12c 
Closes #1287

Authors:
  - Devin Robison (https://github.com/drobison00)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: #1290
@github-project-automation github-project-automation bot moved this from Review - Ready for Review to Done in Morpheus Boards Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drobison00 drobison00

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make dfp_azure_pipeline inference output file configurable. drobison00/devin-morpheus-public
3 participants
@drobison00 @mdemoret-nv @pthalasta