Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA]: Support newer XGBoost model formats #1925

Open
2 tasks done
cwharris opened this issue Oct 2, 2024 · 0 comments
Open
2 tasks done

[FEA]: Support newer XGBoost model formats #1925

cwharris opened this issue Oct 2, 2024 · 0 comments
Labels
feature request New feature or request

Comments

@cwharris
Copy link
Contributor

cwharris commented Oct 2, 2024

Is this a new feature, an improvement, or a change to existing functionality?

New Feature

How would you describe the priority of this feature request

High

Please provide a clear description of problem this feature solves

With the upgrade to RAPIDS 24.10, cuml has changed the default model_type argument for cuml.ForestInference.load from xgboost to the newer universal binary json format. To account for this, the RAPIDS upgrade PR will automatically pass model_type=xgboost to keep tests passing. However, this means users still won't be able to use the newer model formats (ubj and json) with ClassificationStage.

Describe your ideal solution

Update ClassificationStage (gnn-fraud-classification) to support a model_type argument which defaults to None (or accepts a kwarg for the argument) so we pick up the default cuml model_type argument.

Update all xgboost models in the Morpheus repositories to use the new ubj format by loading and re-saving the models.

Update invocations of ClassificationStage to account for the updated models and model_type argument - this may not be necessary after updated the models, assuming they match the default type.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@cwharris cwharris added the feature request New feature or request label Oct 2, 2024
rapids-bot bot pushed a commit that referenced this issue Oct 9, 2024
Closes #1717
Requires nv-morpheus/utilities#75
Requires nv-morpheus/MRC#494

Issues opened during the course of this upgrade:
- #1925

## By Submitting this PR I confirm:
- I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md).
- When the PR is ready for review, new or existing tests cover these changes.
- When the PR is ready for review, the documentation is up to date with these changes.

Authors:
  - Christopher Harris (https://github.com/cwharris)
  - Michael Demoret (https://github.com/mdemoret-nv)

Approvers:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)
  - Tad ZeMicheal (https://github.com/tzemicheal)

URL: #1874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant