Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conda environment yaml's for training-tuning-scripts #1256

Merged
merged 7 commits into from
Oct 13, 2023
Merged

Use conda environment yaml's for training-tuning-scripts #1256

merged 7 commits into from
Oct 13, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Oct 10, 2023 •
edited
Loading

Description

  • Replace requirements.txtfiles (pip) with requirements.yml (conda environment).
  • Update dependency versions.

Closes #1226
Closes #1227

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added dependencies Pull requests that update a dependency file non-breaking Non-breaking change bug Something isn't working improvement Improvement to existing functionality and removed bug Something isn't working labels Oct 10, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@efajardo-nv efajardo-nv marked this pull request as ready for review October 12, 2023 14:49
@efajardo-nv efajardo-nv requested a review from a team as a code owner October 12, 2023 14:49
mdemoret-nv
mdemoret-nv approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. One question, have you re-run all of the scripts with the new environment files to ensure they all work?

@efajardo-nv
Copy link
Contributor Author

This looks great. One question, have you re-run all of the scripts with the new environment files to ensure they all work?

Missed recent autoencoder updates in DFP script and notebook. Fixed now.

@efajardo-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 78c6e3a into nv-morpheus:branch-23.11 Oct 13, 2023
4 checks passed
@efajardo-nv efajardo-nv deleted the training-tuning-req-yamls branch October 13, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
2 participants
@efajardo-nv @mdemoret-nv