Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for LLMUtils #1269

Merged
merged 11 commits into from
Oct 18, 2023
Merged

Add unit tests for LLMUtils #1269

merged 11 commits into from
Oct 18, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Oct 16, 2023 •
edited
Loading

Description

  • Add tests for LLMNode naming conventions

Closes #1271

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components labels Oct 16, 2023
@efajardo-nv efajardo-nv changed the title Add LLM unit tests Add unit tests for LLMUtils Oct 18, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review October 18, 2023 16:11
@efajardo-nv efajardo-nv requested a review from a team as a code owner October 18, 2023 16:11
@mdemoret-nv mdemoret-nv merged commit 54b4d4b into nv-morpheus:fea-sherlock Oct 18, 2023
8 of 10 checks passed
@mdemoret-nv mdemoret-nv deleted the llm-unit-tests branch October 18, 2023 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@efajardo-nv @mdemoret-nv