Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSS Controller Improvements #1285

Merged
merged 9 commits into from
Oct 19, 2023
Merged

RSS Controller Improvements #1285

merged 9 commits into from
Oct 19, 2023

Conversation

bsuryadevara
Copy link
Contributor

@bsuryadevara bsuryadevara commented Oct 17, 2023 •
edited
Loading

Description

  • Added fallback parsing functionality to parse RSS feed using BeautifulSoup library
  • Updated tests

Closes #1274

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@bsuryadevara bsuryadevara changed the title Updated rss controller tests RSS Controller Improvements Oct 17, 2023
@bsuryadevara bsuryadevara linked an issue Oct 17, 2023 that may be closed by this pull request
[FEA]: Improve the RSSSourceStage for Sherlock workflows #1274
Closed
2 tasks
@bsuryadevara bsuryadevara self-assigned this Oct 18, 2023
@bsuryadevara bsuryadevara added non-breaking Non-breaking change improvement Improvement to existing functionality sherlock Issues/PRs related to Sherlock workflows and components labels Oct 18, 2023
@bsuryadevara bsuryadevara marked this pull request as ready for review October 18, 2023 16:55
@bsuryadevara bsuryadevara requested a review from a team as a code owner October 18, 2023 16:55
mdemoret-nv
mdemoret-nv approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions about the implementation

morpheus/controllers/rss_controller.py Outdated Show resolved Hide resolved
morpheus/controllers/rss_controller.py Outdated Show resolved Hide resolved
morpheus/stages/input/rss_source_stage.py Outdated Show resolved Hide resolved
@bsuryadevara
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit ff79139 into nv-morpheus:fea-sherlock Oct 19, 2023
2 of 3 checks passed
@mdemoret-nv mdemoret-nv mentioned this pull request Oct 20, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@bsuryadevara bsuryadevara

Labels
improvement Improvement to existing functionality non-breaking Non-breaking change sherlock Issues/PRs related to Sherlock workflows and components
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Improve the RSSSourceStage for Sherlock workflows
2 participants
@bsuryadevara @mdemoret-nv