-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix shutdown on Ctrl+C for Python source stages #1839
Merged
rapids-bot
merged 19 commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-polling-source-stage-ctrl-c-18337
Aug 14, 2024
Merged
Fix shutdown on Ctrl+C for Python source stages #1839
rapids-bot
merged 19 commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-polling-source-stage-ctrl-c-18337
Aug 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… fixes the Ctrl+C issue
…s the server check
…gs are required to be JSON serializable, move the feed generator into the controller, and update the source stage to use the controller directly
… than sleep for 10 minutes, sleep for 1 second inside loop allowing the controller to stop early if a shutdown is requested
dagardner-nv
changed the title
Fix shutdown logic for Python source stages
Fix shutdown on Ctrl+C for Python source stages
Aug 9, 2024
mdemoret-nv
approved these changes
Aug 14, 2024
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
KafkaSourceStage
already handled this properly, move thestop
method from this class into theSingleOutputSource
.request_stop
andis_stop_requested
methods toSingleOutputSource
.should_stop_fn
constructor argument toDirectoryWatcher
, sources which use the watcher (AutoencoderSourceStage
&AppShieldSourceStage
) pass in theiris_stop_requested
method allowing the watcher to know when to shut down.RSSController
, and update theRSSSourceStage
to use theRSSController
directly rather than the RSS module. This avoids the problem where modules require all config values to be JSON serializable, preventing a callback function from being passed to a module.Closes #1837
By Submitting this PR I confirm: