Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pdf parsing libs #1861

Merged
merged 6 commits into from
Aug 24, 2024
Merged

Replace pdf parsing libs #1861

merged 6 commits into from
Aug 24, 2024

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Aug 23, 2024 •
edited
Loading

Description

By Submitting this PR I confirm:

  • I am familiar with the Contributing Guidelines.
  • When the PR is ready for review, new or existing tests cover these changes.
  • When the PR is ready for review, the documentation is up to date with these changes.

@dagardner-nv dagardner-nv added bug Something isn't working breaking Breaking change ! - Hotfix Related to a Hotfix Release labels Aug 23, 2024
@dagardner-nv dagardner-nv self-assigned this Aug 23, 2024
@dagardner-nv dagardner-nv requested review from a team as code owners August 23, 2024 22:20
@dagardner-nv dagardner-nv marked this pull request as draft August 23, 2024 22:20
@AnuradhaKaruppiah @dagardner-nv
Revert PR_1736 "Always run the PR builder step even if others are can…
206ab08 
…celled" (nv-morpheus#1860)

CIs are failing because of nv-morpheus#1736 not playing well with  rapidsai/shared-workflows#237

As a stopgap I am reverting the changes in nv-morpheus#1736

Authors:
  - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah)

Approvers:
  - David Gardner (https://github.com/dagardner-nv)

URL: nv-morpheus#1860
dagardner-nv and others added 3 commits August 23, 2024 15:54
@dagardner-nv @drobison00
Update examples/llm/vdb_upload/module/content_extractor_module.py
5beb52d 
Co-authored-by: Devin Robison <drobison00@users.noreply.github.com>
@dagardner-nv @drobison00
Update examples/llm/vdb_upload/module/content_extractor_module.py
25236a1 
Co-authored-by: Devin Robison <drobison00@users.noreply.github.com>
@dagardner-nv
Replace PyMuPDF with pypdfium2
f4a2e5f
@dagardner-nv dagardner-nv changed the title Remove PyMuPDF Replace pdf parsing libs Aug 23, 2024
@AnuradhaKaruppiah
Copy link
Contributor

Nice! you turned this into an easy swap out.

@dagardner-nv dagardner-nv marked this pull request as ready for review August 23, 2024 23:41
@dagardner-nv dagardner-nv added feature request New feature or request non-breaking Non-breaking change and removed breaking Breaking change bug Something isn't working labels Aug 23, 2024
@BartleyR
Copy link
Contributor

Reviewed and approved

@BartleyR BartleyR requested review from BartleyR and removed request for BartleyR August 24, 2024 00:04
@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 41eaa84 into nv-morpheus:branch-24.06 Aug 24, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnuradhaKaruppiah AnuradhaKaruppiah AnuradhaKaruppiah approved these changes

@drobison00 drobison00 drobison00 approved these changes

@BartleyR BartleyR BartleyR approved these changes

Assignees

@dagardner-nv dagardner-nv

Labels
! - Hotfix Related to a Hotfix Release feature request New feature or request non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dagardner-nv @AnuradhaKaruppiah @BartleyR @drobison00