-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support LLM pipelines in CPU-only mode #1906
Merged
rapids-bot
merged 347 commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-cpu-only-llm
Oct 18, 2024
Merged
Support LLM pipelines in CPU-only mode #1906
rapids-bot
merged 347 commits into
nv-morpheus:branch-24.10
from
dagardner-nv:david-cpu-only-llm
Oct 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Stage) as supporting both GPU and CPU
…avid-cpu-only-mode-1846
…is that now that Python mode is synonymous with CPU mode, execution in CPU mode will now be considered a special case and not the general case
…, this is a hold-over from the POC
… this doesn't appear to be used anymore and we're changing the definition of C++ & Python mode
… pipelines which require Python messages
…cudf helpers are loaded
…das & cudf object columns are handled
/ok to test |
…avid-cpu-only-mode-1846
…as these come at a cost
… based on the use_cudf marker
/ok to test |
/ok to test |
mdemoret-nv
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont love it but I dont know any other way right now.
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Oct 18, 2024
* Documents writing a stage that supports CPU execution mode * Updates `docs/source/developer_guide/contributing.md` cleaning up build and troubleshooting sections. Requires PRs #1851 & #1906 to be merged first Closes [#1737](#1737) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) - Yuchen Zhang (https://github.com/yczhang-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: #1924
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MessageMeta
a pandas DF, however theLLMEngineStage
is implemented in C++ and only compatible with the C++ impl ofMessageMeta
with a cudf DF.MessageMeta
within theControlMessage
metadata which is able to store a Python object as-is.--use_cpu_only
flag is givenRequires PR #1851 to be merged first
By Submitting this PR I confirm: