Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pybind11-stubgen to v2.4.2 #89

Open
wants to merge 6 commits into
base: branch-25.02
Choose a base branch
from

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Dec 3, 2024

Description

  • Changes required to update pybind11-stubgen
  • Between our current version 0.10.5 and 1.0 the tool underwent a complete re-write which removed/changed several command line flags
  • Due to the way pybind11-stubgen writes stub files, we now first write the stub then move it to the correct location/name.
  • The --ignore-invalid-identifiers flag is needed since at build-time the python extensions are built but not yet installed into the Python env.
  • Disable stub building for Cython modules, the reason is that pybind11-stubgen includes the repr output for PyCapsule which includes the memory location of the object, thus causing the stub output to change with each build ref: Optionally disable the # value = ... in Printer sizmailov/pybind11-stubgen#235. In addition to this we don't expose any Cython functions to Python, thus removing the need for building stubs of Cython modules.

Needed for nv-morpheus/Morpheus#2074

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change 5 - DO NOT MERGE PR should not be merged; see PR for details 2 - In Progress PR/Issue is currently a work in progress labels Dec 3, 2024
@dagardner-nv dagardner-nv self-assigned this Dec 3, 2024
@dagardner-nv dagardner-nv requested a review from a team as a code owner December 3, 2024 19:10
@dagardner-nv dagardner-nv marked this pull request as draft December 3, 2024 19:10
@dagardner-nv dagardner-nv added 3 - Ready for Review PR/Issue is complete and ready for review by team improvement Improvement to existing functionality and removed 5 - DO NOT MERGE PR should not be merged; see PR for details 2 - In Progress PR/Issue is currently a work in progress labels Dec 3, 2024
@dagardner-nv dagardner-nv marked this pull request as ready for review December 3, 2024 20:49
@dagardner-nv dagardner-nv marked this pull request as draft December 3, 2024 22:36
…hon modules which we call from Python, and newer versions of stubgen cause unique stubs to be built with each build even in the absense of changes ref: sizmailov/pybind11-stubgen#235
…om value reprs instead of the ... values stubgen will use
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review PR/Issue is complete and ready for review by team improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant