-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pybind11-stubgen to v2.4.2 #89
Open
dagardner-nv
wants to merge
6
commits into
nv-morpheus:branch-25.02
Choose a base branch
from
dagardner-nv:david-stubgen-2074
base: branch-25.02
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update pybind11-stubgen to v2.4.2 #89
dagardner-nv
wants to merge
6
commits into
nv-morpheus:branch-25.02
from
dagardner-nv:david-stubgen-2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore-invalid-identifiers flag avoids issue where not all symbols are loaded into the current Python env
dagardner-nv
added
non-breaking
Non-breaking change
5 - DO NOT MERGE
PR should not be merged; see PR for details
2 - In Progress
PR/Issue is currently a work in progress
labels
Dec 3, 2024
dagardner-nv
added
3 - Ready for Review
PR/Issue is complete and ready for review by team
improvement
Improvement to existing functionality
and removed
5 - DO NOT MERGE
PR should not be merged; see PR for details
2 - In Progress
PR/Issue is currently a work in progress
labels
Dec 3, 2024
3 tasks
…hon modules which we call from Python, and newer versions of stubgen cause unique stubs to be built with each build even in the absense of changes ref: sizmailov/pybind11-stubgen#235
…om value reprs instead of the ... values stubgen will use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
PR/Issue is complete and ready for review by team
improvement
Improvement to existing functionality
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
pybind11-stubgen
0.10.5
and1.0
the tool underwent a complete re-write which removed/changed several command line flagspybind11-stubgen
writes stub files, we now first write the stub then move it to the correct location/name.--ignore-invalid-identifiers
flag is needed since at build-time the python extensions are built but not yet installed into the Python env.pybind11-stubgen
includes therepr
output forPyCapsule
which includes the memory location of the object, thus causing the stub output to change with each build ref: Optionally disable the# value = ...
inPrinter
sizmailov/pybind11-stubgen#235. In addition to this we don't expose any Cython functions to Python, thus removing the need for building stubs of Cython modules.Needed for nv-morpheus/Morpheus#2074
Checklist