-
-
Notifications
You must be signed in to change notification settings - Fork 646
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
82 additions
and
51 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,51 +1,6 @@ | ||
<!-- Please read and fill in the following template, for an explanation of the sections see: | ||
https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md | ||
Please also note that the NVDA project has a Citizen and Contributor Code of Conduct which can be found at https://github.com/nvaccess/nvda/blob/master/CODE_OF_CONDUCT.md. NV Access expects that all contributors and other community members read and abide by the rules set out in this document while participating or contributing to this project. This includes creating or commenting on issues and pull requests. | ||
Please initially open PRs as a draft. | ||
When you would like a review, mark the PR as "ready for review". | ||
See https://github.com/nvaccess/nvda/blob/master/.github/CONTRIBUTING.md. | ||
--> | ||
|
||
### Link to issue number: | ||
|
||
### Summary of the issue: | ||
|
||
### Description of user facing changes | ||
|
||
### Description of development approach | ||
|
||
### Testing strategy: | ||
|
||
### Known issues with pull request: | ||
|
||
### Code Review Checklist: | ||
|
||
<!-- | ||
This checklist is a reminder of things commonly forgotten in a new PR. | ||
Authors, please do a self-review of this pull-request. | ||
Check items to confirm you have thought about the relevance of the item. | ||
Where items are missing (eg unit / system tests), please explain in the PR. | ||
To check an item `- [ ]` becomes `- [x]`, note spacing. | ||
You can also check the checkboxes after the PR is created. | ||
A detailed explanation of this checklist is available here: | ||
https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md#code-review-checklist | ||
--> | ||
|
||
- [ ] Documentation: | ||
- Change log entry | ||
- User Documentation | ||
- Developer / Technical Documentation | ||
- Context sensitive help for GUI changes | ||
- [ ] Testing: | ||
- Unit tests | ||
- System (end to end) tests | ||
- Manual testing | ||
- [ ] UX of all users considered: | ||
- Speech | ||
- Braille | ||
- Low Vision | ||
- Different web browsers | ||
- Localization in other languages / culture than English | ||
- [ ] API is compatible with existing add-ons. | ||
- [ ] Security precautions taken. | ||
You have arrived at the generic template for submitting PRs. | ||
Your PR may be closed if you do not follow one of the following PR templates. | ||
Hint: Swap to the preview tab to be able to click the links. | ||
Direct links to the templates: | ||
- [A code or documentation contribution](?expand=1&template=default.md) | ||
- [A Pull Request revert](?expand=1&template=revert.md) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
--- | ||
name: Code or documentation contribution (default) | ||
about: Generic template used for most code or documentation contributions | ||
|
||
--- | ||
|
||
<!-- Please read and fill in the following template, for an explanation of the sections see: | ||
https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md | ||
Please also note that the NVDA project has a Citizen and Contributor Code of Conduct which can be found at https://github.com/nvaccess/nvda/blob/master/CODE_OF_CONDUCT.md. NV Access expects that all contributors and other community members read and abide by the rules set out in this document while participating or contributing to this project. This includes creating or commenting on issues and pull requests. | ||
Please initially open PRs as a draft. | ||
When you would like a review, mark the PR as "ready for review". | ||
See https://github.com/nvaccess/nvda/blob/master/.github/CONTRIBUTING.md. | ||
--> | ||
|
||
### Link to issue number: | ||
|
||
### Summary of the issue: | ||
|
||
### Description of user facing changes | ||
|
||
### Description of development approach | ||
|
||
### Testing strategy: | ||
|
||
### Known issues with pull request: | ||
|
||
### Code Review Checklist: | ||
|
||
<!-- | ||
This checklist is a reminder of things commonly forgotten in a new PR. | ||
Authors, please do a self-review of this pull-request. | ||
Check items to confirm you have thought about the relevance of the item. | ||
Where items are missing (eg unit / system tests), please explain in the PR. | ||
To check an item `- [ ]` becomes `- [x]`, note spacing. | ||
You can also check the checkboxes after the PR is created. | ||
A detailed explanation of this checklist is available here: | ||
https://github.com/nvaccess/nvda/blob/master/projectDocs/dev/githubPullRequestTemplateExplanationAndExamples.md#code-review-checklist | ||
--> | ||
|
||
- [ ] Documentation: | ||
- Change log entry | ||
- User Documentation | ||
- Developer / Technical Documentation | ||
- Context sensitive help for GUI changes | ||
- [ ] Testing: | ||
- Unit tests | ||
- System (end to end) tests | ||
- Manual testing | ||
- [ ] UX of all users considered: | ||
- Speech | ||
- Braille | ||
- Low Vision | ||
- Different web browsers | ||
- Localization in other languages / culture than English | ||
- [ ] API is compatible with existing add-ons. | ||
- [ ] Security precautions taken. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
--- | ||
name: Revert PR | ||
about: Revert an existing pull request | ||
|
||
--- | ||
|
||
### Reverts PR | ||
Reverts #issueNumber | ||
|
||
### Reason for revert | ||
|
||
### Issues fixed | ||
<!-- Issues that will be closed by reverting, i.e. the issues introduced via the PR getting reverted --> | ||
Fixes #issueNumber | ||
|
||
|
||
### Issues reopened | ||
<!-- Issues that will be re-opened by reverting, i.e. the issues that were fixed via the PR getting reverted --> | ||
Reopens #issueNumber |