Skip to content

Commit

Permalink
Fix handling of table cells without a containing table in browse mode. (
Browse files Browse the repository at this point in the history
#8887)

* Fix handling of table cells without a containing table in browse mode.

In the new Gmail, message bodies are contained within a "gridcell" which does not have a containing grid.
The gridcell's name is the entire body of the message.
When using quick navigation to move to anything inside these "cells", NVDA reports information about the cell, including its name, after the element to which you just navigated.
This results in a huge amount of spurious (and confusing) verbosity in Gmail when using quick navigation.
To fix this, cells outside of tables are now treated as layout.

* Update what's new.
  • Loading branch information
jcsteh authored and michaelDCurran committed Oct 29, 2018
1 parent fd24d81 commit 5fe34c5
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion source/textInfos/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ def getPresentationCategory(self, ancestors, formatConfig, reason=controlTypes.R
break
else:
table = None
if table and ((not formatConfig["includeLayoutTables"] and table.get("table-layout", None)) or table.get('isHidden',False)):
if not table or (not formatConfig["includeLayoutTables"] and table.get("table-layout", None)) or table.get('isHidden',False):
return self.PRESCAT_LAYOUT
if reason in (controlTypes.REASON_CARET, controlTypes.REASON_SAYALL, controlTypes.REASON_FOCUS) and (
(role == controlTypes.ROLE_LINK and not formatConfig["reportLinks"])
Expand Down
1 change: 1 addition & 0 deletions user_docs/en/changes.t2t
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ What's New in NVDA
- NVDA no longer fails to track focus in File Explorer and other applications using UI Automation when another app is busy (such as batch processing audio). (#7345)
- In ARIA menus on the web, the Escape key will now be passed through to the menu and no longer turn off focus mode unconditionally. (#3215)
- NVDA no longer refuses to report the focus on web pages where the new focus replaces a control that no longer exists. (#6606, #8341)
- In the new Gmail, when using quick navigation inside messages while reading them, the entire body of the message is no longer reported after the element to which you just navigated. (#8887)
- In BrowseMode, NVDA will now always report labels on divs and spans explicitly set by the web author. (#8886)


Expand Down

0 comments on commit 5fe34c5

Please sign in to comment.