-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a script to toggle language detection #10253
Comments
I up-vote the need for this feature. Almost of topic: NVDA currently behaves differently in matter of language switching when hovering with the mouse or reading in browse mode. Quite annoying. |
For now speech settings ring gathers only parameters from the synthesizer. All these parameters appear before automatic language switching option in the speech setting panel and are provided by the synthesizer. |
I would just like to second this feature request. Very useful.
I am ambivalent about whether it fits with synth settings ring. There is some
argument to be made for the convenience of it, and for not waisting another
keystroke.
On the other hand, it doesn't really fit the other things in the "synth" ring.
|
Integrating this feature in the synth settings ring seems to require modifications in each one of the synth driver. Indeed it is the synth driver which defines the settings that it supports in the ring. Moreover, the driver then implements the functions to get and set each setting in the ring. This would thus create a bunch of dependencies with synth drivers to upgrade... Really overkill for such a minor change. |
Actually, the base class could add this setting for its derived implementations.
Currently, the language detection is toggled globally, whether the chosen synth driver supports the feature or not.
Again, the base class can handle this. I'm not nitpicking because I think this setting should be included in the ring. |
@JulienCochuyt, thanks for your comments that are welcome and valuable. I agree with you to concentrate mainly on the targetted user experience. If we choose to integrate language detection in the ring, this would be the moment to really think which parameters should remain in the ring. E.g., I never modify the voice pitch on the fly and do not think many people do. Any comment from someone else having an experience of NVDA synth framework would be welcome. I do not know so much who has looked at or worked on such topics. @feerrenrut ? |
This is actually a feature I would much appreciate to see in NVDA core.
I agree, even though I fear it is always harder for end users to accept removal of feature than to accept additions or increased configurability.
One of the questions might be: Are there synth that do support it for some voices and not for others? |
Hello, |
Vigorously seconding having an unassigned gesture for automatic language switching. I currently go NVDA+Ctrl+V > Alt+O > Tab > Spacebar > Enter, which is a bit cumbersome. I do this frequently because while learning a new language that uses the same alphabet , in my experience, I find it clarifying to read Spanish text with both their English and Spanish pronunciations. |
Fixes #10253 Summary of the issue: A gesture is missing to control automatic language switching and automatic dialect switching options. Description of how this pull request fixes the issue: Add an unassigned script that cycles through the 3 following automatic language and dialect switching modes: - Language and dialect switching off - Language switching on, dialect switching off - Language and dialect switching on Note that the 4th possible state (language switching off and dialect switching on) does not make sense.
Is your feature request related to a problem? Please describe.
In some cases, I need to deactivate auto-language switching:
On the opposite, sometimes I prefer have auto-language switching on to get used to real language pronunciation.
Pressing NVDA+Ctrl+V to go to voice settings panel, then tabbing in the dialog box to go to auto language switching option, activate it and press Enter is a bit long.
Describe the solution you'd like
Add a script to toggle automatic language switching. Such scripts exist for many other setting panels options, so this would be coherent. The script may be unassigned and could be assigned by the user as already done for many other such setting toggle scripts.
The script could also include auto dialect switching option and toggle between 3 states:
Note that the 4th possible state (language detection off and dialect on) does not make sense to me.
Describe alternatives you've considered
Additional context
I have a personal script that does the job here:
https://raw.githubusercontent.com/CyrilleB79/NVDAScripts/master/globalPlugins/autoLangSwitch.py
The text was updated successfully, but these errors were encountered: