Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

braille is not updated in excel when undoing #15547

Closed
burmancomp opened this issue Sep 28, 2023 · 0 comments · Fixed by #15595
Closed

braille is not updated in excel when undoing #15547

burmancomp opened this issue Sep 28, 2023 · 0 comments · Fixed by #15595
Labels
component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone
2024.1

Comments

@burmancomp
Copy link
Contributor

Steps to reproduce:

  • do not use UIA for spreadsheet controls (NVDA settings -> advanced)
  • type text to empty cell
  • move to other cell
  • move back to previous cell
  • press control+z

Actual behavior:

cell contains text you typed.

Expected behavior:

cell should be empty.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

from source

NVDA version:

current main branch

Windows version:

windows 10 2022h2

Name and version of other software in use when reproducing the issue:

office 2019

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

If NVDA add-ons are disabled, is your problem still occurring?

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?
@burmancomp burmancomp changed the title braille is not updated when undoing braille is not updated in excel when undoing Sep 28, 2023
@seanbudd seanbudd added component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Oct 2, 2023
@burmancomp burmancomp mentioned this issue Oct 8, 2023
Merged
5 tasks
seanbudd pushed a commit that referenced this issue Oct 10, 2023
@burmancomp
Update braille and speak active cell and its content in MS Excel when…
88e5cf6 
… UIA is not used and control+y, control+z or alt+backspace is pressed (#15595)

fixes #15547

Summary of the issue:
When UIA is not used and control+y (redo), control+z / alt+backspace (undo) is pressed, braille is not updated and active cell and its content is not spoken.

Description of user facing changes
Braille is updated and active cell with its content is spoken.

Description of development approach
Added gestures control+y, control+z and alt+backspace to NVDAObjects.window.excel.ExcelWorksheet.script_changeSelection.
@nvaccessAuto nvaccessAuto added this to the 2024.1 milestone Oct 10, 2023
@CyrilleB79 CyrilleB79 mentioned this issue Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/braille p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Milestone
2024.1
3 participants
@seanbudd @nvaccessAuto @burmancomp