Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text paragraph navigation: report when entering and leaving a role while reading the paragraph #16143

Closed
Adriani90 opened this issue Feb 7, 2024 · 1 comment · Fixed by #16145
Milestone

Comments

@Adriani90
Copy link
Collaborator

Steps to reproduce:

  1. With NVDA running, open the github repository of NVDA and go to insights
  2. Using browse mode, navigate to the first link "skip to content"
  3. Press p to jump to the next text paragraph

Actual behavior:

NVDA reports
"Excluding merges, 6 authors have pushed 10 commits to master and 15 commits to all branches. On master, 83 files have changed and there have been 1,435 additions and 828 deletions link."
This is confusing because the user doesn't know where exactly the link is and over which part of the text it spans.

Expected behavior:

NVDA should report:
"Excluding merges, 6 authors have pushed 10 commits to master and 15 commits to all branches. On master, 83 files have changed and there have been Link 1,435 additions and 828 deletions end of link."

NVDA logs, crash dumps and other attachments:

n/a

System configuration

NVDA installed/portable/running from source:

Installed

NVDA version:

alpha-30972,9717b815 (2024.2.0.30972)

Windows version:

Windows 11 23 H2

Name and version of other software in use when reproducing the issue:

Firefox 122.0.1

Other information about your system:

n/a

Other questions

Does the issue still occur after restarting your computer?

yes

Have you tried any other versions of NVDA? If so, please report their behaviors.

no

If NVDA add-ons are disabled, is your problem still occurring?

yes

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

yes

@Adriani90
Copy link
Collaborator Author

cc: @mltony

seanbudd pushed a commit that referenced this issue Feb 11, 2024
Closes #16143

Summary of the issue:
NVDA reports roles incorrectly when navigating using P quickNav

Description of user facing changes
Fixed speech so that p quickNav command behaves as expected.

Description of development approach
A quick investigation shows that this is the behavior of speech.speakTextInfo(info, reason=OutputReason.QUICKNAV) as called in browseMode.py:216. I didn't change that in textNav PR.

This makes sense for other QuickNav commands. For example on that page if you press B, you get:

Open global navigation menu Button
Note that the word button goes in the end. If you stumble upon the same button via Control+Up/Down then the speech is

Button Open global navigation menu
So since text paragraph navigation is more similar to caret navigation in the sense that it navigates to text that might contain different roles, I propose to change to reason=OutputReason.CARET for text paragraph navigation as it seems to fix this issue.
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Feb 11, 2024
Nael-Sayegh pushed a commit to Nael-Sayegh/nvda that referenced this issue Feb 15, 2024
Closes nvaccess#16143

Summary of the issue:
NVDA reports roles incorrectly when navigating using P quickNav

Description of user facing changes
Fixed speech so that p quickNav command behaves as expected.

Description of development approach
A quick investigation shows that this is the behavior of speech.speakTextInfo(info, reason=OutputReason.QUICKNAV) as called in browseMode.py:216. I didn't change that in textNav PR.

This makes sense for other QuickNav commands. For example on that page if you press B, you get:

Open global navigation menu Button
Note that the word button goes in the end. If you stumble upon the same button via Control+Up/Down then the speech is

Button Open global navigation menu
So since text paragraph navigation is more similar to caret navigation in the sense that it navigates to text that might contain different roles, I propose to change to reason=OutputReason.CARET for text paragraph navigation as it seems to fix this issue.
Adriani90 pushed a commit to Adriani90/nvda that referenced this issue Mar 13, 2024
Closes nvaccess#16143

Summary of the issue:
NVDA reports roles incorrectly when navigating using P quickNav

Description of user facing changes
Fixed speech so that p quickNav command behaves as expected.

Description of development approach
A quick investigation shows that this is the behavior of speech.speakTextInfo(info, reason=OutputReason.QUICKNAV) as called in browseMode.py:216. I didn't change that in textNav PR.

This makes sense for other QuickNav commands. For example on that page if you press B, you get:

Open global navigation menu Button
Note that the word button goes in the end. If you stumble upon the same button via Control+Up/Down then the speech is

Button Open global navigation menu
So since text paragraph navigation is more similar to caret navigation in the sense that it navigates to text that might contain different roles, I propose to change to reason=OutputReason.CARET for text paragraph navigation as it seems to fix this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants