Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apps mute and volume features work very unexpectedly with WASAPI disabled #16409

Closed
XLTechie opened this issue Apr 17, 2024 · 5 comments · Fixed by #16440
Closed

Apps mute and volume features work very unexpectedly with WASAPI disabled #16409

XLTechie opened this issue Apr 17, 2024 · 5 comments · Fixed by #16440
Labels
bug/regression p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Milestone

Comments

@XLTechie
Copy link
Collaborator

Steps to reproduce:

  1. IN NVDA Advanced settings, set WASAPI to disabled.
  2. Apply, save config, and restart NVDA.
  3. Start some sound playing. I used Firefox, playing a video.
  4. Attempt to mute other apps (NVDA+Alt+Del).
  5. Attempt to change volume of other apps (NVDA+Alt+pgDn).
  6. Continue lowering volume of other apps to 20 or so.
  7. In NVDA Advanced settings, enable WASAPI.
  8. Save config and restart NVDA.

Actual behavior:

At step 4, NVDA says:

Sound split cannot be used. Please enable WASAPI in the Advanced category in NVDA Settings to use it.
Applications muted

First,. I was not trying to use Sound Split. Why is it being mentioned?
Second, Applications have not been muted, so the message is false.

At step 5, NVDA says:

Sound split cannot be used. Please enable WASAPI in the Advanced category in NVDA Settings to use it.
Applications volume 95

First, I was not using Sound Split, again.
Second, the application volume was not changed, so the message is false.

At step 8:

Upon NVDA restart, the volume of the other application--which was previously not changed--suddenly drops precipitously to match the volume that was set while WASAPI was disabled.

Expected behavior:

At step 4, NVDA should speak only something like:

Application mute is only supported when WASAPI is enabled in NVDA advanced settings.

At step 5, NVDA should speak only something like:

Application volume changes are only supported when WASAPI is enabled in NVDA advanced settings.

At step 8, the volume should not change on NVDA startup, because step 4 should not have changed any volume in configuration.

NVDA logs, crash dumps and other attachments:

System configuration

NVDA installed/portable/running from source:

Portable.

NVDA version:

alpha-31622,11a2b4f1

Windows version:

11 HOME 23H3

Name and version of other software in use when reproducing the issue:

N/A

Other information about your system:

Other questions

Does the issue still occur after restarting your computer?

N/A

Have you tried any other versions of NVDA? If so, please report their behaviors.

No.

If NVDA add-ons are disabled, is your problem still occurring?

Yes.

Does the issue still occur after you run the COM Registration Fixing Tool in NVDA's tools menu?

Of course.

@XLTechie
Copy link
Collaborator Author

cc @mltony
Also @CyrilleB79 as a possibly interested party.

@XLTechie XLTechie changed the title Apps mute and volume features work strangely with WASAPI disabled Apps mute and volume features work very unexpectedly with WASAPI disabled Apr 17, 2024
@Adriani90
Copy link
Collaborator

As far as I know these features are designed to work well only with WASAPI, and the setting to disable WASAPI might be completely removed from the GUI. What is the reason you are not using WASAPI?
Cc: @jcsteh

@XLTechie
Copy link
Collaborator Author

XLTechie commented Apr 17, 2024 via email

@jcsteh
Copy link
Contributor

jcsteh commented Apr 19, 2024

As long as WASAPI CAN be disabled, other features should work correctly in that scenario.

That might be true if disabling WASAPI were not an advanced setting, but on the contrary, it is an advanced setting. The advanced settings section has a very clear disclaimer about the potential hazards of changing these settings: "I understand that changing these settings may cause NVDA to function incorrectly."

I don't think users should have to justify using a core NVDA feature that is not even scheduled for removal.

On the contrary, they should - and they accept the associated risk - because it's an advanced setting.

All of that said, it looks like this is being addressed in #16404 anyway.

@seanbudd
Copy link
Member

Our plan is to revert this feature

@seanbudd seanbudd added bug/regression p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation. labels Apr 23, 2024
@seanbudd seanbudd added this to the 2024.2 milestone Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/regression p3 https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/triage.md#priority triaged Has been triaged, issue is waiting for implementation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants