-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EdgeHTML: support aria-role=alert #8466
Comments
… then allows live region changed event to work. Re nvaccess#8466. When alerts are received, Edge fires live region changed event. However, the name of this element is empty, but thankfully, its children's names are text fragmenets. Therefore set name property by traversing its children, which then allows live region changed event to work.
Reviewed by @LeonarddeR (Babbage): because concatenation only works on first-level descendant, it may not pick up additional text from deeper descendants. Therefore use tree interceptor content as the element's name, which still allows live region changed event to work (thank you Leonard for this tip).
…#8466. Reviewed by @LeonarddeR (Babbage): just to make sure: tree interceptor must be live in order for tree interceptor based solution to work.
Hi, In consideration for people using older Windows 10 releases, I advise not closing this issue even when Chromium Edge stable version is released. Thanks. |
Hi, Actually, it would be best to close this for now as Chromium Edge is about to go live. We will revisit this problem if there are situations where this must be resolved. Thanks. |
Are there any plans for Edge to support |
Hi, at least for EdgeHTML Edge, not at the moment as it is deprecated. Chromium-based Edge 79 and later might be the place to add this functionality. Thanks.
From: Stefany Newman <notifications@github.com>
Sent: Wednesday, January 29, 2020 8:09 AM
To: nvaccess/nvda <nvda@noreply.github.com>
Cc: Joseph Lee <joseph.lee22590@gmail.com>; State change <state_change@noreply.github.com>
Subject: Re: [nvaccess/nvda] EdgeHTML: support aria-role=alert (#8466)
Are there any plans for Edge to support role="alert"?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub <#8466?email_source=notifications&email_token=AB4AXEEOCS77NRSRPQWWMODRAGSY3A5CNFSM4FHXHSU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEKHYLAA#issuecomment-579831168> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB4AXEGXUFYHMFSZLXOLKLLRAGSY3ANCNFSM4FHXHSUQ> .
|
Hi, 2021 update: Microsoft noted that support for legacy Edge powered by EdgeHTML has ended as of March 9, 2021. Therefore, it is becoming unlikely that this issue will be reopened again. Thanks. |
Hi,
Somewhat related to #8448: In Microsoft Edge, aria-role=alert is not supported yet.
Steps to reproduce:
Actual behavior:
No feedback from NVDA in Microsoft Edge.
Expected behavior:
NVDA should announce alert text.
System configuration:
NVDA Installed/portable/running from source:
Installed
NVDA version:
Next.15445
Windows version:
Windows 10 Version 1803
Name and version of other software in use when reproducing the issue:
Microsoft Edge
Other information about your system:
Multiple systems, all part of Windows Insider Program.
Other questions:
Does the issue still occur after restarting your PC?
Yes
Have you tried any other versions of NVDA?
Yes - master, 2018.2.1
Technical details
Alerts are fired as live region changed events. It was used to be system alert, but apparently this has changed (need to verify this). Probing the element with ariaProperties says role=alert, which should then allow NVDAObjects.UIA.edge.EdgeNode.event_liveRegionChanged handler to fetch alert texts and announce it. Note that the name might be an empty string, but child count might be greater than 1, in which case probing the children should do.
Thanks.
The text was updated successfully, but these errors were encountered: