Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EdgeHTML: support aria-role=alert #8466

Closed
josephsl opened this issue Jun 30, 2018 · 6 comments
Closed

EdgeHTML: support aria-role=alert #8466

josephsl opened this issue Jun 30, 2018 · 6 comments
Labels
z app/edge (archived) use app/edge/anaheim z app/edge/spartan (archived) MS browser, replaced in 2019 by Anaheim. NVDA access via UIA.

Comments

@josephsl
Copy link
Collaborator

Hi,

Somewhat related to #8448: In Microsoft Edge, aria-role=alert is not supported yet.

Steps to reproduce:

  1. Visit the following site with multiple web browsers, including with Edge: https://www.w3.org/TR/wai-aria-practices/examples/alert/index.html
  2. Click "trigger alert" button.

Actual behavior:

No feedback from NVDA in Microsoft Edge.

Expected behavior:

NVDA should announce alert text.

System configuration:

NVDA Installed/portable/running from source:

Installed

NVDA version:

Next.15445

Windows version:

Windows 10 Version 1803

Name and version of other software in use when reproducing the issue:

Microsoft Edge

Other information about your system:

Multiple systems, all part of Windows Insider Program.

Other questions:

Does the issue still occur after restarting your PC?

Yes

Have you tried any other versions of NVDA?

Yes - master, 2018.2.1

Technical details

Alerts are fired as live region changed events. It was used to be system alert, but apparently this has changed (need to verify this). Probing the element with ariaProperties says role=alert, which should then allow NVDAObjects.UIA.edge.EdgeNode.event_liveRegionChanged handler to fetch alert texts and announce it. Note that the name might be an empty string, but child count might be greater than 1, in which case probing the children should do.

Thanks.

@josephsl josephsl changed the title EdgeHTML: suppot aria-role=alert EdgeHTML: support aria-role=alert Jun 30, 2018
@josephsl
Copy link
Collaborator Author

CC @tgeczy, @michaelDCurran

josephsl added a commit to josephsl/nvda that referenced this issue Jun 30, 2018
… then allows live region changed event to work. Re nvaccess#8466.

When alerts are received, Edge fires live region changed event. However, the name of this element is empty, but thankfully, its children's names are text fragmenets. Therefore set name property by traversing its children, which then allows live region changed event to work.
josephsl added a commit to josephsl/nvda that referenced this issue Jul 2, 2018
Reviewed by @LeonarddeR (Babbage): because concatenation only works on first-level descendant, it may not pick up additional text from deeper descendants. Therefore use tree interceptor content as the element's name, which still allows live region changed event to work (thank you Leonard for this tip).
josephsl added a commit to josephsl/nvda that referenced this issue Jul 2, 2018
…#8466.

Reviewed by @LeonarddeR (Babbage): just to make sure: tree interceptor must be live in order for tree interceptor based solution to work.
@josephsl
Copy link
Collaborator Author

Hi,

In consideration for people using older Windows 10 releases, I advise not closing this issue even when Chromium Edge stable version is released.

Thanks.

@josephsl
Copy link
Collaborator Author

Hi,

Actually, it would be best to close this for now as Chromium Edge is about to go live. We will revisit this problem if there are situations where this must be resolved.

Thanks.

@stefany-newman
Copy link

Are there any plans for Edge to support role="alert"?

@josephsl
Copy link
Collaborator Author

josephsl commented Jan 29, 2020 via email

@Adriani90 Adriani90 added z app/edge (archived) use app/edge/anaheim z app/edge/spartan (archived) MS browser, replaced in 2019 by Anaheim. NVDA access via UIA. labels Apr 30, 2020
@josephsl
Copy link
Collaborator Author

Hi,

2021 update: Microsoft noted that support for legacy Edge powered by EdgeHTML has ended as of March 9, 2021. Therefore, it is becoming unlikely that this issue will be reopened again.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
z app/edge (archived) use app/edge/anaheim z app/edge/spartan (archived) MS browser, replaced in 2019 by Anaheim. NVDA access via UIA.
Projects
None yet
3 participants