-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AddonsDialog: some add-ons are marked as Enabled when NVDA is launched with --disable-addons flag #9473
Comments
Confirmed. My recommended action/fix would be to:
|
I agree. Will try to implement this soon! |
The dialog is still useful, allowing users to get information about their addons and uninstall them. This is particularly useful if an addon is causing a usability problem. |
No, do not disable the dialog, just disable the option to enable or
disable the add-ons, as well as show each add-on as disabled while in
this mode.
…On 4/9/19, Reef Turner ***@***.***> wrote:
> I am wondering if we shouldn't disable this dialog and its menu entry all
> together.
The dialog is still useful, allowing users to get information about their
addons and uninstall them. This is particularly useful if an addon is
causing a usability problem.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#9473 (comment)
|
Hi, I'm wondering if the root problem is #6275? I'll do some tests to see if it is indeed a mistake from that one with 2018.4. Thanks. |
Hi, Yep, testing shows this is a regression. Thanks. |
Clarification to the text in the add-on manager when NVDA is launched with the --disable-addons flag. (Issue #9473)
Steps to reproduce:
--disable-addons
flag.Actual behavior:
Add-ons that are enabled on your profile will appear as enabled on the dialog.
Expected behavior:
Since NVDA has been told to start with all add-ons disabled, and since they are effectively not running, they shouldn't appear as enabled.
I found this when looking at #5785.
Since a label indicates that you must restart NVDA to re-enable your add-ons, and because the
--disable-addons
will likely be used by people who know what they're doing, I am wondering if we shouldn't disable this dialog and its menu entry all together.System configuration
NVDA installed/portable/running from source:
NVDA Installed.
NVDA version:
NVDA 2019.1.
Windows version:
Windows 10 Education version 1809.
Other questions
Does the issue still occur after restarting your PC?
Yes.
Have you tried any other versions of NVDA?
No.
The text was updated successfully, but these errors were encountered: