Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Automation in Windows Console: text review behaves inconsistently when the window is maximized #9891

Closed
codeofdusk opened this issue Jul 7, 2019 · 1 comment · Fixed by #9957
Milestone

Comments

@codeofdusk
Copy link
Contributor

Steps to reproduce:

  1. Open Command Prompt with UIA enabled.
  2. Maximize the window.
  3. In a git repository, run git log.

Actual behavior:

Text review gets stuck.

Expected behavior:

Text review shows all the visible text.

System configuration

NVDA installed/portable/running from source:

Source and installed.

NVDA version:

Latest master.

Windows version:

Windows 10 1903.

Name and version of other software in use when reproducing the issue:

Command Prompt/Windows Console

Other information about your system:

Other questions

Does the issue still occur after restarting your PC?

Yes.

Have you tried any other versions of NVDA? If so, please report their behaviors.

No.

@codeofdusk
Copy link
Contributor Author

This bug is almost definitely in the bounds checking code in consoleUIATextInfo.move, as it does not occur when running #9735 with review unbounded. Cc @feerrenrut @LeonarddeR

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Aug 1, 2019
feerrenrut pushed a commit that referenced this issue Aug 1, 2019
…e checks (PR #9957)

Builds on #9614
Supersedes #9735 and #9899
Closes #9891

Previously, after the console window was maximized (or the review cursor is otherwise placed outside the visible text), text review is no longer functional.
The review top line and review bottom line scripts do not function as intended.

This commit changes:
- The isOffscreen property has been implemented as UIAUtils.isTextRangeOffscreen.
- When checking if the text range is out of bounds, we now also check that oldRange is in bounds before stopping movement.
- Re-implemented POSITION_FIRST and POSITION_LAST in terms of visible ranges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment