You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This bug is almost definitely in the bounds checking code in consoleUIATextInfo.move, as it does not occur when running #9735 with review unbounded. Cc @feerrenrut@LeonarddeR
…e checks (PR #9957)
Builds on #9614
Supersedes #9735 and #9899Closes#9891
Previously, after the console window was maximized (or the review cursor is otherwise placed outside the visible text), text review is no longer functional.
The review top line and review bottom line scripts do not function as intended.
This commit changes:
- The isOffscreen property has been implemented as UIAUtils.isTextRangeOffscreen.
- When checking if the text range is out of bounds, we now also check that oldRange is in bounds before stopping movement.
- Re-implemented POSITION_FIRST and POSITION_LAST in terms of visible ranges.
Steps to reproduce:
git log
.Actual behavior:
Text review gets stuck.
Expected behavior:
Text review shows all the visible text.
System configuration
NVDA installed/portable/running from source:
Source and installed.
NVDA version:
Latest master.
Windows version:
Windows 10 1903.
Name and version of other software in use when reproducing the issue:
Command Prompt/Windows Console
Other information about your system:
Other questions
Does the issue still occur after restarting your PC?
Yes.
Have you tried any other versions of NVDA? If so, please report their behaviors.
No.
The text was updated successfully, but these errors were encountered: