V2 of UI Automation in Windows Console: fix setEndPoint/compareEndPoints #10057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feerrenrut
suggested changes
Aug 8, 2019
Co-Authored-By: Reef Turner <feerrenrut@users.noreply.github.com>
|
PR introduces Flake8 errors 😲 See test results for Failed build of commit 8d3e66f60a |
feerrenrut
reviewed
Aug 9, 2019
| otherEndPoint = "Start" | ||
| which = f"{selfEndPoint}To{otherEndPoint}" | ||
| return super().setEndPoint(other, which=which) | ||
|
|
||
| def _get_hasNoText(self): | ||
| def _get__isCollapsed(self): |
There was a problem hiding this comment.
Do we actually benefit from caching in this case? If not, I think I would prefer not to use the auto-property form and just name it def _isCollapsed(self)
There was a problem hiding this comment.
Nope, caching for this property would actually be pretty harmful if the text info is changes during one core cycle.
codeofdusk
added a commit
to codeofdusk/nvda
that referenced
this pull request
Aug 13, 2019
…cess#10057)" This reverts commit 39d20e2.
This was referenced Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #10035. Related to #9614. Identical to #10043.
Summary of the issue:
Braille does not properly track the system caret in Windows Console.
Description of how this pull request fixes the issue:
#9802 introduced a patched implementation of
_get_isCollapsed. As suggested by @LeonarddeR, this code has been factored out into a new_endPointHelpermethod which normalizes endPoints forcompareEndPointsandsetEndPoint(used by_get_isCollapsed, Braille support, and possibly others).Testing performed:
Tested that the
isCollapsedproperty behaves as expected (in the Python console). Testing by @LeonarddeR indicates that Braille behaves as expected after the change.Known issues with pull request:
None.
Change log entry:
None.