-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pr11650 with fix for addon paths #11707
Conversation
… made absolute as soon as possible to protect against the current directory changing later on. Also store NVDA's app dir in globalVars.
…ars.appDir calls.
…n places where we can't be completely sure the path is absolute.
…in NVDAHelper and nvda_slave when loading NvDAHelperRemote.
…g them to stop an infinite while loop introduced in #11650
for those reviewing, only commit 2ae3811 is new. |
I can successfully run this commit with NVDARemote. But I would welcome testing by others. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least add-ons are working.
This is a replacement of pr #11650 containing all original commits, but with one extra commit that stops an infinite while loop in addonHandler.getCodeAddon when loading an addon that has translations (such as nvdaRemote).