No longer copy Python dll manually as latest version of Py2exe no longer invalidates its signature. #12142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest version of Py2exe no longer invalidates signature of Python's dll so this workaround is no longer needed
michaelDCurran
approved these changes
Mar 11, 2021
|
I verified a try build could be produced without errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, Related to #9762 and #9796
Summary of the issue:
The build of Py2exe that we were using up to now had a bug which caused signature of Python's dll to be corrupted effectively making it impossible to sign .appx packages. This problem has been worked around in #9796. Since we're updating to a later version of Py2exe without this bug it makes sense to remove our workaround.
Description of how this pull request fixes the issue:
The code from #9796 has been removed.
Testing strategy:
Created .appx package with a certificate ensured that signing process succeeded.
Known issues with pull request:
This should be tested on AppVeyor with a try branch just to make sure.
Change log entry:
None needed this affects build system.
Code Review Checklist:
This checklist is a reminder of things commonly forgotten in a new PR.
Authors, please do a self-review and confirm you have considered the following items.
Mark items you have considered by checking them.
You can do this when editing the Pull request description with an x:
[ ]becomes[x].You can also check the checkboxes after the PR is created.