Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff used for linting changes to the list of files ignored by git #12169

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

lukaszgo1
Copy link
Contributor

Link to issue number:

None - problem introduced by #12075

Summary of the issue:

When linting changes to NVDA it is necessary to create a diff between base branch and the changes. This diff was not ignored by git.

Description of how this pull request fixes the issue:

_lint.diff has been added to the .gitignore

Testing strategy:

Ensured that _lint.diff is no longer shown as an untracked file in git.

Known issues with pull request:

None known

Change log entry:

None needed

Code Review Checklist:

  • Pull Request description is up to date.
  • Unit tests.
  • System (end to end) tests.
  • Manual tests.
  • User Documentation.
  • Change log entry.
  • Context sensitive help for GUI changes.

@AppVeyorBot
Copy link

See test results for failed build of commit 1b07d114dc

@michaelDCurran michaelDCurran merged commit ef8a0d4 into nvaccess:master Mar 16, 2021
@nvaccessAuto nvaccessAuto added this to the 2021.1 milestone Mar 16, 2021
@lukaszgo1 lukaszgo1 deleted the ignoreDiffForLinter branch March 16, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants