-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a release blurb and fixup changes for 2021.2 #12700
Conversation
user_docs/en/changes.t2t
Outdated
|
||
== Important notes == | ||
- Screen Curtain on previous releases of NVDA is no longer compatible with versions of Windows newer than Windows 10 21H2 (10.0.19044). | ||
Screen Curtain is no longer compatible when using versions of NVDA older than 2021.2 with Windows newer than Windows 10 21H2 (10.0.19044). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newer than
Shouldn't this be "when using x or later"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually yes, that is the case as far as I'm aware. Before I fix this (across the rest of the documentation) I'm going to check this via the release preview channel for WIN1021H2. I have confirmed the previous release of Windows works, Windows 10 21H1.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change of behaviour occurred in an insiders build, #12491 reports this change of behaviour for a build sometime after the WIN10 21H2
build number. I am yet to be able to test WIN10 21H2
preview (haven't been offered the update). It would be good if someone can confirm whether or not screen curtain works with the WIN10 21H2
preview, but for now I will move forward to say "when using it or later" due to being uncertain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think this is fine.
Just a couple of ideas, trying to make the language for the screen curtain edge cases as simple as possible.
00fa3ee
@feerrenrut - I've rephrased this message across both files now. Let me know what you think. |
Description
Adds a release blurb and proposes some changes to the changelog and userGuide.
Testing strategy
I performed a review of
git diff release-2021.1 userDocsChanges2021.2 user_docs/en/*.t2t
.The build artifact for
changes.html
anduserGuide.html
should be checked before merging.Code Review Checklist: