-
-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI Automation in Windows Console: expose all three config options in preparation for usage by default #13807
Conversation
It was requested in nvaccess#10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability. This commit exposes the ternary option as requested and updates the user guide in preparation for PR nvaccess#10964. Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
50e3fd5
to
256cdb3
Compare
See test results for failed build of commit 05958c44f6 |
See test results for failed build of commit 16e1eb8a64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @codeofdusk - code changes look good. I've reformatted the userGuide changes slightly.
@seanbudd I can't see your user guide changes. Have they been committed yet? |
Co-authored-by: Sean Budd <seanbudd123@gmail.com>
See test results for failed build of commit a4a3e4631c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User guide changes read well, good work!
Follow-up of nvaccess#13807. Co-authored-by: Łukasz Golonka <lukasz.golonka@mailbox.org>
Link to issue number:
Blocking #10964.
Summary of the issue:
It was requested in #10964 (comment) that the ternary option be exposed separately to the change in default behaviour to ease revertability.
Description of how this pull request fixes the issue:
Exposes the ternary option as requested and updates the user guide.
Testing strategy:
Tested that all three values of the combo box update the config as expected (including that "automatic" uses the legacy support).
Known issues with pull request:
None known.
Change log entries:
None needed (update changelog as part of #10964).
Code Review Checklist: