Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed Add-on Store user guide section revisions #14961

Closed

Conversation

XLTechie
Copy link
Collaborator

@XLTechie XLTechie commented Jun 5, 2023

Replaced by PR #14966

Luke Davis added 19 commits June 5, 2023 04:03
…-ons are, and explain that it being a "store" does not mean users must pay.
…e first one to "Filtering for enabled or disabled add-ons".
…uctory section, explaining enabled/disabled states.
…. Moved explanations before usage instructions.
…isplay name, publisher and description.", because there are no instructions.
…", because that has been used to describe NV Access accepting add-ons into the store, by some members in the community, and I wanted to make clear that they are not "vetted" in any way.
@XLTechie XLTechie marked this pull request as ready for review June 5, 2023 08:36
@XLTechie XLTechie requested a review from a team as a code owner June 5, 2023 08:36
@XLTechie XLTechie requested review from Qchristensen and removed request for a team June 5, 2023 08:36
@XLTechie
Copy link
Collaborator Author

XLTechie commented Jun 5, 2023

@seanbudd and/or @Qchristensen While I did not try to change it here, why are we still using the old "addonsManager" internal link to reach the add-on store section of the user guide? I vaguely remember this being explained somewhere, but not sure where.

In any case, it seems strange since the store is an entirely new concept.

@CyrilleB79
Copy link
Collaborator

@seanbudd and/or @Qchristensen While I did not try to change it here, why are we still using the old "addonsManager" internal link to reach the add-on store section of the user guide? I vaguely remember this being explained somewhere, but not sure where.

In any case, it seems strange since the store is an entirely new concept.

In the wild, there may be links on the user guide targeting this paragraph. Keeping the old add-on manager anchor allows to avoid these links to be broken and to point to the paragraph which describes what has become the add-on manager.

@XLTechie
Copy link
Collaborator Author

XLTechie commented Jun 5, 2023

In the wild, there may be links on the user guide targeting this paragraph. Keeping the old add-on manager anchor allows to avoid these links to be broken

So would creating an HTML anchor immediately before the Add-on Store section, that manually redirects links there, while still enabling us to name the chapter appropriately. E.g.:

'''
<a style="visibility: hidden" name="AddonsManager">&nbsp;</a>
'''

That is valid T2T code, according to the spec.

@CyrilleB79
Copy link
Collaborator

In the wild, there may be links on the user guide targeting this paragraph. Keeping the old add-on manager anchor allows to avoid these links to be broken

So would creating an HTML anchor immediately before the Add-on Store section, that manually redirects links there, while still enabling us to name the chapter appropriately. E.g.:

Yes, this fully makes sense to me.

@seanbudd seanbudd deleted the branch nvaccess:addonStore-base June 5, 2023 23:41
@seanbudd seanbudd closed this Jun 5, 2023
@seanbudd
Copy link
Member

seanbudd commented Jun 5, 2023

Strangely, GitHub will not let me re-open and re-target this PR

@XLTechie
Copy link
Collaborator Author

XLTechie commented Jun 6, 2023

Opened as a new PR with a clean branch. Had to cherry-pick it back into master, as it wouldn't let me rebase in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants