Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on store: only make directories if should write to disk #14968

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

seanbudd
Copy link
Member

@seanbudd seanbudd commented Jun 6, 2023

Link to issue number:

Fix up of #14955
Raised in #14912 (comment)

Summary of the issue:

Caching directories are still created when NVDA should not write to disk

Description of user facing changes

Caching directories are no longer created when NVDA should not write to disk

Description of development approach

Caching directories are no longer created when NVDA should not write to disk

Testing strategy:

Refer to #14955

Known issues with pull request:

N/a

Change log entries:

N/a

Code Review Checklist:

  • Pull Request description:
    • description is up to date
    • change log entries
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • API is compatible with existing add-ons.
  • Documentation:
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • Security precautions taken.

@seanbudd seanbudd requested a review from a team as a code owner June 6, 2023 03:57
@seanbudd seanbudd requested a review from michaelDCurran June 6, 2023 03:57
@seanbudd seanbudd merged commit 7b91697 into master Jun 6, 2023
@seanbudd seanbudd deleted the addonStoreDirCreation branch June 6, 2023 05:29
@nvaccessAuto nvaccessAuto added this to the 2023.2 milestone Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants