Add-on Store: Remove invalid cache file

[seanbudd]

Link to issue number:

Closes #15106

Summary of the issue:

If NVDA has an invalid add-on store cache file it can be safely deleted until a new cache is fetched.
Without deleting it, NVDA will start with an error until it is overwritten by browsing add-ons.

Description of user facing changes

If NVDA has invalid cache data for the add-on store, NVDA will log an exception then delete the invalid cache file.

Description of development approach

If NVDA has invalid cache data for the add-on store, NVDA will log an exception then delete the invalid cache file.

Testing strategy:

Test invalid cache file

Known issues with pull request:

None

Change log entries:

N/A

Code Review Checklist:

• Pull Request description:
  • description is up to date
  • change log entries
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• API is compatible with existing add-ons.
• Documentation:
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• Security precautions taken.

[AppVeyorBot]

• PASS: Translation comments check.
• PASS: Unit tests.
• PASS: Lint check.
• FAIL: System tests (tags: installer NVDA). See test results for more information.
• Build (for testing PR): https://ci.appveyor.com/api/buildjobs/0l8cfusxkt383dhl/artifacts/output/nvda_snapshot_pr15111-28641,e3556a1e.exe
• CI timing (mins):
  INIT 0.0,
  INSTALL_START 0.8,
  INSTALL_END 0.8,
  BUILD_START 0.0,
  BUILD_END 22.0,
  TESTSETUP_START 0.0,
  TESTSETUP_END 0.3,
  TEST_START 0.0,
  TEST_END 21.3,
  FINISH_END 0.1

See test results for failed build of commit e3556a1ea0

[XLTechie]

@seanbudd is this prevented from running in installer/temporary copies?

I ask because I have installed the snapshot of this build.
However, after doing so, neither the current run log, or the previous log, show the expected exception.

On the positive side, it solves the problem I reported in the referenced issue. However now I'm concerned that it removed the cache while the installer was running, which goes back to an older consideration.

[seanbudd]

Fixed, thanks @XLTechie