-
-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup 'Temporary Copy restrictions' in the user guide #15222
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seanbudd, @Qchristensen, that is not true (at least for NVDA 2023.2beta1).
Indeed, modifying the gestures is allowed while running temp version of NVDA.
I think that the idea was to prevent writing on disk in temp versions only if it might cause issue with the installed version. E.g.: writing the config the config (settings) on the disk is not allowed because the config scheme (version) may be different and incompatible between installer and installed version. On the contrary writing gestures from a newer version does not cause any problem to older version: non-existing scripts are just silently ignored by the older version. If NVAccess changes the behaviour, it should be clarified and the reasons of it should be explained to developers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been fixed up in #15248
Note that the intention was actually to prevent any config from being saved to disk, as NVDA should be treated as a fully temporary copy in this case. This will be addressed in 2023.3 with more clear restrictions around secure screens, and temporary copies