Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Guide: Indicate incompatibility of screen curtain with inverted colors in the Magnifier #16258

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

CyrilleB79
Copy link
Collaborator

@CyrilleB79 CyrilleB79 commented Mar 4, 2024

Link to issue number:

Partial fix for #10545

Summary of the issue:

Screen curtain cannot be activated while Windows Magnifier is running with inverted screen colors.
An error message can be heard when trying to activate the screen curtain.
Though, this incompatibility is not documented in the User Guide.

Description of user facing changes

Update the User Guide.

Description of development approach

N/A

Testing strategy:

Check User Guide.

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@CyrilleB79 CyrilleB79 marked this pull request as ready for review March 4, 2024 19:00
@CyrilleB79 CyrilleB79 requested a review from a team as a code owner March 4, 2024 19:00
@CyrilleB79 CyrilleB79 requested a review from Qchristensen March 4, 2024 19:00
@seanbudd
Copy link
Member

seanbudd commented Mar 5, 2024

I don't think this should close #10545. While its good to document this behaviour, I think #12701 is needed to close #10545. Thoughts?

@seanbudd
Copy link
Member

seanbudd commented Mar 5, 2024

Is there a UX message or just an error sound when screen curtain fails to activate?

@Qchristensen
Copy link
Member

When trying to enable screen curtain with Magnifier on (windows+numpad plus) and set to invert colours (control+alt+i), NVDA speaks "Could not enable screen curtain". No error dialog is presented. The follow log fragment is generated:

IO - inputCore.InputManager.executeGesture (11:42:00.359) - winInputHook (14740):
Input: kb(desktop):control+NVDA+escape
DEBUG - visionEnhancementProviders.screenCurtain.ScreenCurtainProvider.init (11:42:00.361) - MainThread (5216):
Starting ScreenCurtain
WARNING - vision.visionHandler.VisionHandler.initializeProvider (11:42:00.361) - MainThread (5216):
Error initialising screenCurtain. Disabling in config.
ERROR - globalCommands._enableScreenCurtain (11:42:00.361) - MainThread (5216):
Screen curtain initialization error
Traceback (most recent call last):
File "globalCommands.pyc", line 4332, in _enableScreenCurtain
File "vision\visionHandler.pyc", line 261, in initializeProvider
File "vision\visionHandler.pyc", line 256, in initializeProvider
File "visionEnhancementProviders\screenCurtain.pyc", line 354, in init
File "visionEnhancementProviders\screenCurtain.pyc", line 350, in init
File "visionEnhancementProviders\screenCurtain.pyc", line 42, in _errCheck
OSError: [WinError 87] The parameter is incorrect.
IO - speech.speech.speak (11:42:00.378) - MainThread (5216):
Speaking [LangChangeCommand ('en_GB'), 'Could not enable screen curtain']

Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User guide text reads well

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Mar 5, 2024
@CyrilleB79
Copy link
Collaborator Author

There are 4 ways to activate screen curtain:

  • using the gesture (now NVDA+control+escape): a ui.message reports "Could not enable screen curtain"
  • checking the checkbox in Vision settings: an error dialog box is displayed
  • triggered by profile switching: nothing is reported; only error ding can be heard in test builds
  • when starting NVDA: nothing is reported; only error ding can be heard in test builds

I agree that #10545 should remain open until something is reported in these four cases. #12701 may be a solution but another solution based on error catching in the two last cases is also acceptable IMO; What do you think?

In any case, I have updated the initial description to remove the auto-closing word so that the documentation update can already be merged.

@seanbudd seanbudd merged commit 2f9df19 into nvaccess:master Mar 6, 2024
1 check passed
@nvaccessAuto nvaccessAuto added this to the 2024.2 milestone Mar 6, 2024
@CyrilleB79 CyrilleB79 deleted the ugScreenCurtain branch March 6, 2024 09:10
Adriani90 pushed a commit to Adriani90/nvda that referenced this pull request Mar 13, 2024
…colors in the Magnifier (nvaccess#16258)

Partial fix for nvaccess#10545

Summary of the issue:
Screen curtain cannot be activated while Windows Magnifier is running with inverted screen colors.
An error message can be heard when trying to activate the screen curtain.
Though, this incompatibility is not documented in the User Guide.

Description of user facing changes
Update the User Guide.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants