-
-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable cursor movement with braille display routing keys in PowerPoint #17004
Conversation
WalkthroughThe recent updates introduce a new method in the PowerPoint module that allows for more precise control of the text caret position. Additionally, NVDA has been enhanced to support braille display routing keys for moving the text cursor within PowerPoint documents. This significantly improves accessibility for users relying on braille displays, making it easier for them to interact with text in PowerPoint presentations. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
@SaschaCowley This is lovely. Could you also implement |
… selection commands (NVDA+F9/F10) work in PowerPoint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me generally, nice work on this
Co-authored-by: Sean Budd <sean@nvaccess.org>
Link to issue number:
Closes #9101
Summary of the issue:
The routing keys on a braille display do not work to move the text insertion point in Microsoft PowerPoint.
Description of user facing changes
The routing keys now move the cursor in PowerPoint.
Description of development approach
Looked at
TextFrameTextInfo
to look at how access to PowerPoint text works. Used the Microsoft Powerpoint Object Model documentation to find the appropriate methods. Implemented a_setCaretOffset
implementation onTextFrameTextInfo
.Sources:
TextRange
object (of note are theTextRange.Characters
andTextRange.Select
methods.Testing strategy:
Manually tested with an old NV Access presentation.
Known issues with pull request:
None.
Code Review Checklist:
Summary by CodeRabbit