Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLS eReader Zoomax braille driver #17509

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

florin-trutiu
Copy link

@florin-trutiu florin-trutiu commented Dec 12, 2024

Link to issue number:

Closes #15863

Summary of the issue:

This is the NVDA driver for the NLS eReader Zoomax braille display.
It supports both USB and Bluetooth automatic detection.

Description of user facing changes

With this driver the user can use directly the NLS eReader Zoomax display without the need to manually install it as an addon.

Description of development approach

The driver is similar with the existing braille display drivers for NVDA.

Testing strategy:

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@florin-trutiu florin-trutiu requested a review from a team as a code owner December 12, 2024 11:23
@seanbudd seanbudd self-requested a review December 12, 2024 22:56
@seanbudd
Copy link
Member

Thanks for opening this PR @florin-trutiu !

  • Please fill out the PR template
  • Please remove this line from the userGuide:
    * Note that the Zoomax is currently not supported without external drivers
  • Please add a changelog entry in changes.md noting that support for this braille device has been added

@seanbudd
Copy link
Member

pre-commit.ci autofix

@florin-trutiu florin-trutiu requested a review from a team as a code owner December 13, 2024 11:34
@florin-trutiu
Copy link
Author

florin-trutiu commented Dec 13, 2024

Thanks for opening this PR @florin-trutiu !

  • Please fill out the PR template
  • Please remove this line from the userGuide:
    * Note that the Zoomax is currently not supported without external drivers
  • Please add a changelog entry in changes.md noting that support for this braille device has been added

@seanbudd
Removed the mentioned line.
I noticed that the line was in the Huwanware section because of a confusion, there are two NLS eReader braille displays. one is manufactured by Humanware and one by Zoomax.
So to avoid confusion I appended the Humanware name to the NLS eReader device mentioned in the Humanware displays section.

In the user guide I have now added a section for the NLS eReader Zoomax braille display.

@CyrilleB79
Copy link
Collaborator

@florin-trutiu, you have added the template, but for completeness, could you please writing the required information in its sections rather than writing before it? Thanks!

@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NLS E-Reader Zoomax braille display should possibly be supported by NVDA, but isn't
4 participants