Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a reference to the launcher audio logo from the quick start guide #17519

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

nidza07
Copy link
Contributor

@nidza07 nidza07 commented Dec 13, 2024

Link to issue number:

None

Summary of the issue:

In #17507, the audio logo played while the NVDA launcher is loading has been removed. However, the quick start guide still makes a reference to the music playing before a temporary copy of NVDA loads.

Description of user facing changes

The quick start guide no longer includes misleading information. Instead, it has been replaced with a note that it may take a few seconds for the temporary copy to load.

Description of development approach

Replaced the information in the user guide.

Testing strategy:

Check the user guide, ensuring there are no references to the launcher music.

Known issues with pull request:

None known.

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@nidza07 nidza07 requested a review from a team as a code owner December 13, 2024 21:35
@nidza07 nidza07 requested a review from Qchristensen December 13, 2024 21:35
user_docs/en/userGuide.md Outdated Show resolved Hide resolved
@SaschaCowley SaschaCowley added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 17, 2024
@SaschaCowley SaschaCowley added this to the 2025.1 milestone Dec 17, 2024
Copy link
Member

@Qchristensen Qchristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reads well

@seanbudd seanbudd merged commit ada7908 into nvaccess:master Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants