Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix math not being read in Chromium-based browsers (#17421) #17548

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Fix math not being read in Chromium-based browsers (#17421) #17548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db9a295
Fix math not being read in Chromium-based browers. Chromium made a ch…
NSoiffer Dec 15, 2024
f866ffc
update changes and version info
seanbudd Dec 16, 2024
aa2c220
Merge remote-tracking branch 'origin/rc' into fix-17421
seanbudd Dec 19, 2024
f082b31
Update user_docs/en/changes.md
seanbudd Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion source/NVDAObjects/IAccessible/ia2Web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
)
from ctypes import c_short
from comtypes import COMError, BSTR
from comtypes.hresult import E_NOTIMPL

import oleacc
from annotation import (
Expand Down Expand Up @@ -334,7 +335,13 @@ def _get_mathMl(self):
# Try the data-mathml attribute.
attrNames = (BSTR * 1)("data-mathml")
namespaceIds = (c_short * 1)(0)
attr = node.attributesForNames(1, attrNames, namespaceIds)
try:
attr = node.attributesForNames(1, attrNames, namespaceIds)
except COMError as e:
if e.hresult != E_NOTIMPL:
log.debugWarning(f"MathML getting attr error: {e}")
raise
attr = None
if attr:
import mathPres

Expand Down
5 changes: 4 additions & 1 deletion user_docs/en/changes.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,11 @@

## 2024.4.2

### Bug Fixes
This is a patch release to fix bugs with braille devices and reading math in Chromium.

### Bug fixes

* Fixed bug with with reading math in Chromium Browsers (Chrome, Edge). (#17421, @NSoiffer)
* Humanware Brailliant BI 40X devices running firmware version 2.4 now work as expected. (#17518, @bramd)

## 2024.4.1
Expand Down
Loading