Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix braille table loading with debug logging enabled and/or add-ons disabled #17565

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

LeonarddeR
Copy link
Collaborator

Link to issue number:

None

Summary of the issue:

When custom braille tables are available in the manifest of the scratchpad and NVDA starts with debug logging enabled, it will raise an unbound local error due to a wrong logging statement. This actually revealed another bug, namely that scratchpad braille tables weren't ignored when addons are disabled.

Description of user facing changes

No longer an error in this specific case. Furthermore, custom braille tables from the scratchpad wil be disabled when addons are.

Description of development approach

  1. Fixed the debug logging statement
  2. in brailleTables.initialize, return early when add-ons disabled or when appX.

Testing strategy:

Tested from source that the error no longer occurs and that scratchpad tables are no longer loaded

Known issues with pull request:

None

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@coderabbitai summary

@LeonarddeR LeonarddeR requested a review from a team as a code owner December 21, 2024 08:25
@LeonarddeR LeonarddeR changed the title Fix braille table loading with debug logging enabled Fix braille table loading with debug logging enabled and/or add-ons disabled Dec 21, 2024
@AppVeyorBot
Copy link

See test results for failed build of commit 2a0c5cc8a1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants