Fix up of: Don't announce 'selected' when the focus moves in Google sheets if the focused cell is the only cell selected #8898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e focused cell is the only cell selected.
…, and announces 'not selected' for not selected items, to controls that have the focusable state.
… childID coming from accSelection, as found in QT tree tables like in Mumble
feerrenrut
approved these changes
Oct 31, 2018
|
I"m getting messages like "selected expanded" or "selected collapsed" when expanding or collapsing folders in the thunderbird tree view. I don't consider it very relevant, but it is definitely caused by this pr, I think. |
This was referenced Nov 28, 2018
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Jul 15, 2019
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Jul 15, 2019
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
JulienCochuyt
added a commit
to accessolutions/nvda
that referenced
this pull request
Aug 13, 2019
…in Google sheets if the focused cell is the only cell selected (nvaccess#8898)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up of pr #8879.
Contains one last commit which ensures this change is only limited to focusable items, such as ARIA gridcells. This is necessary as otherwise 'not selected' is reported for standard html tables both in focus and browse modes.
Testing performed:
Same as PR #8879, but also: