UI Automation in Windows Console: add focus redirection for the UIA console main window #9674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeofdusk
force-pushed
the
cmduia3-focusredirect
branch
from
5a824fb to
c21af0a
Compare
LeonarddeR
suggested changes
Jun 6, 2019
LeonarddeR
approved these changes
Jun 7, 2019
| def findExtraOverlayClasses(obj, clsList): | ||
| if obj.UIAElement.cachedAutomationId == "Text Area": | ||
| clsList.append(winConsoleUIA) | ||
| if obj.UIAElement.cachedAutomationId == "Console Window": |
There was a problem hiding this comment.
Please make this an elif
michaelDCurran
approved these changes
Jun 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Builds on #9614.
Summary of the issue:
Currently, in UIA consoles:
Description of how this pull request fixes the issue:
This PR adds focus redirection from the console application's window to its text area.
Testing performed:
On Windows 10 1903 with UIA console support enabled:
Before this change: NVDA became unable to interact with the console.
After this change: NVDA's console interaction was unaffected.
Known issues with pull request:
None known.
Change log entry:
None.