Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

Update py2exe with upstream, add patch for #2

Merged
merged 2 commits into from
Jul 2, 2019
Merged

Update py2exe with upstream, add patch for #2

merged 2 commits into from
Jul 2, 2019

Conversation

LeonarddeR
Copy link
Contributor

This updates py2exe to master from upstream, including the patch from py2exe/py2exe#13, which fixes a major bug for us.

@LeonarddeR
Copy link
Contributor Author

@feerrenrut: This blocks several issues, so if you could review this ASAP, that would be appreciated!

@feerrenrut feerrenrut self-assigned this Jul 2, 2019
@feerrenrut
Copy link
Contributor

This looks fine, but I think this should be merged into threshold_py3_staging not master?

@feerrenrut
Copy link
Contributor

Ignore that last comment... different repo

feerrenrut
feerrenrut suggested changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@feerrenrut feerrenrut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the readme file as well. I think the only change necessary is to the version number:

Suggestion: '0.9.3.2' (in development - see commit <SHA>/ link to py2exe project)

@LeonarddeR
Copy link
Contributor Author

LeonarddeR commented Jul 2, 2019 via email

@feerrenrut feerrenrut merged commit c496ae6 into nvaccess:master Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feerrenrut feerrenrut feerrenrut approved these changes

Assignees

@feerrenrut feerrenrut

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeonarddeR @feerrenrut