feat: Support viewing SVG if import as ReactComponent #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jest-preview-library canceled.
|
nvh95
force-pushed
the
support-svg-component
branch
from
7692d93 to
5f706f7
Compare
nvh95
force-pushed
the
support-svg-component
branch
from
3b6267f to
5625a85
Compare
|
@ntt261298 I can make it work for now. I haven't tested much but at least we know that it's feasible. As in the above image. The Vite logo is where we import it as |
nvh95
changed the title
nvh95
approved these changes
Jul 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/ Motivation (TLDR;)
Related issues
ReactComponent) #180Features
import { ReactComponent as Logo } from './logo.svg';Chores
playgroundfolder to contains snippets, which help us validate our idea faster.