Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

191 update docs introduction section #196

Merged
merged 6 commits into from
Jul 18, 2022

Conversation

skirianov
Copy link
Collaborator

Summary/ Motivation (TLDR;)

General refactoring/rewriting of the Introduction page.

Note: this is just preview PR, once changes are discussed and approved before merge "Why Jest Preview" link will be removed.

Related issues

Features

  • Removed Features page
  • Fit Features content into the Introduction page
  • Changed wording
  • Added Stackblitz embedded in the docs
  • Add more formatting and Info boxes
  • Add links to future Why Jest Preview

Fixes

  • N/A

Chores

  • N/A

@skirianov skirianov linked an issue Jul 12, 2022 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Jul 12, 2022

Deploy Preview for jest-preview-library ready!

Name Link
🔨 Latest commit d028b8b
🔍 Latest deploy log https://app.netlify.com/sites/jest-preview-library/deploys/62d53925cdd006000a921a8b
😎 Deploy Preview https://deploy-preview-196--jest-preview-library.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Owner

@nvh95 nvh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please revert the changes in yarn.lock. Currently, we are using npm for package managing
  • Please revert the change in website/docs/others/contributing.md

Comment on lines 4 to 15

# Contributing

## Welcome

Welcome to CONTRIBUTING zone. If you are reading this, you probably want to contribute to Open Source projects. That's great! Contributing to an open source project is a great opportunity to learn, sharpen your skills and help others. Luckily, Jest Preview is a free and open source project and we always welcome new contributors. Its mission is to help front end developers' lives easier and more enjoyable, also improve the standard of front end applications by encouraging them to write more high-quality tests, by providing an ability to view the actual UI in Jest in an external browser like Chrome.

Jest Preview aims to be a community-driven project. So we hope to see your contributions to make Jest Preview a favorite library for front end developers when it comes to testing.

## What can I contribute?

We appreciated any help. There is not a thing as a small contribution. If you see a typo, send us a PR. If you experience a bug, please open an issue. If you have a suggestion, let us know. Below are some ways you can contribute to Jest Preview:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, when building the docs website, we will copy the content from CONTRIBUTING.md to website/docs/others/contributing.md.
You can see the source code here and the docs website that already has contributing guideline:
https://www.jest-preview.com/docs/others/contributing

(You can see that contributing is duplicated in https://deploy-preview-196--jest-preview-library.netlify.app/docs/others/contributing)

I guess you want to reverse the changes in this file.
If you want to update contributing guideline, please make the change directly in CONTRIBUTING.md

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


## Online Demo

You can try Jest Preview right on the browser without installing or cloning anything, thanks to [StackBlitz](https://stackblitz.com/):
Want to try the library before installing it? We got you covered! Check out [StackBlitz Demo App](https://stackblitz.com/edit/jest-preview?embed=1&file=package.json) or try it right here 😉
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to README.md instead of package.json

Suggested change
Want to try the library before installing it? We got you covered! Check out [StackBlitz Demo App](https://stackblitz.com/edit/jest-preview?embed=1&file=package.json) or try it right here 😉
Want to try the library before installing it? We got you covered! Check out [StackBlitz Demo App](https://stackblitz.com/edit/jest-preview?file=README.md) or try it right here 😉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to Readme.md


You also need to start the Jest Preview Server by running the CLI `jest-preview`. Please continue to read [Usage](/docs/getting-started/usage) for the details instructions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a suggestion here. Since the simple instruction above does not support CSS and viewing images yet. So we mention something like "To make it look even better, follow the Installation guide"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added Installation guide link as per your suggestion

Copy link
Owner

@nvh95 nvh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nvh95 nvh95 merged commit 4fd60d9 into main Jul 18, 2022
@nvh95 nvh95 deleted the 191-update-docs-introduction-section branch July 18, 2022 13:34
@nvh95
Copy link
Owner

nvh95 commented Jul 18, 2022

@all-contributors please add @skirianov for doc and content

@allcontributors
Copy link
Contributor

@nvh95

I've put up a pull request to add @skirianov! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update docs Introduction section
2 participants