Simplify styled-components + Inject css to document.head
#79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jest-preview-library canceled.
|
This was
linked to
issues
Apr 24, 2022
nvh95
changed the title
document.head
nvh95
force-pushed
the
styled-components-simplify
branch
from
37325a1 to
200c76f
Compare
ntt261298
reviewed
May 4, 2022
| @@ -10,21 +10,11 @@ export function debug(element: Element = document.body): void { | |||
| }); | |||
| } | |||
|
|
|||
| // If user use styled-components | |||
| if (getStyle) { | |||
There was a problem hiding this comment.
Can we safely remove ./styled-components now?
There was a problem hiding this comment.
For sure. I will remove that.
We don't need to access to styled-component's internal to make jest preview works anymore. But at least I learned a lot of how styled-components works
sonngdev
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
styled-component's CSS to disk (cache folder)head, instead ofbodyChores
npm run test:onlytonpm run test:dev