Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update references of tsserver to ts_ls #1131

Merged
merged 1 commit into from
Sep 10, 2024
Merged

feat: update references of tsserver to ts_ls #1131

merged 1 commit into from
Sep 10, 2024

Conversation

Cheveniko
Copy link
Contributor

@Cheveniko Cheveniko commented Sep 6, 2024 •
edited
Loading

nvim-lspconfig renamed tsserver to ts_ls (see this PR)

This causes a warning everytime you start nvim because Mason hasn't changed tsserver name to ts_ls.

This PR fixes it by adding an if statement to check if the server name is tsserver and updates it to ts_ls in mason-lspconfig.setup (Credits)

Also it replaces every reference of tsserver to ts_ls

@Cheveniko Cheveniko mentioned this pull request Sep 6, 2024
Closed
BraedenKilburn
BraedenKilburn reviewed Sep 6, 2024
View reviewed changes
init.lua
-- But for many setups, the LSP (`tsserver`) will work just fine
-- tsserver = {},
-- But for many setups, the LSP (`ts_ls`) will work just fine
-- ts_ls = {},

This comment was marked as outdated.

Sign in to view

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I missed that 😵

It should remain tsserver in case anyone uncomments it

@shivambegin
Copy link

this is ready to merge as mason also renamed tsserver to ts_ls

@samarth-na
Copy link

this should be added as soon as possible

@Cheveniko
Copy link
Contributor Author

Cheveniko commented Sep 9, 2024 •
edited
Loading

Mason updated tsserver name to ts_ls (See this issue) so the fix isn't necessary anymore.

I've updated the commit to remove the fix and only update every reference of tsserver to ts_ls

AndreCostaaa added a commit to AndreCostaaa/kickstart.nvim that referenced this pull request Sep 9, 2024
@AndreCostaaa
chore: tsserver is now called ts_ls
9acf405 
nvim-lua#1131
@yonas yonas mentioned this pull request Sep 10, 2024
Closed
@feoh feoh merged commit 7201dc4 into nvim-lua:master Sep 10, 2024
1 check passed
Soimil added a commit to Soimil/kickstart.nvim that referenced this pull request Sep 11, 2024
@Soimil
Merge pull request #13 from nvim-lua/master
5e8ed0a 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
codemedic added a commit to codemedic/kickstart.nvim that referenced this pull request Sep 11, 2024
@codemedic
Merge branch 'master' into codemedic-customisations
385d755 
* master:
  feat: update references of tsserver to ts_ls (nvim-lua#1131)
  Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)
  cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)
  fix: remove deprecated opt for conform.nvim (nvim-lua#1070)
  Fix: updated the windows installation commands (nvim-lua#1101)
  Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)
  Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)
  refactor: update treesitter and which-key config (nvim-lua#1068)
  Check for loop or uv for lazypath (nvim-lua#1095)
  Add note in README about lazy-lock.json (nvim-lua#1090)
  Update README.md (nvim-lua#1091)
Braxion06 added a commit to Braxion06/brax.nvim that referenced this pull request Sep 12, 2024
@Braxion06
Merge pull request #1 from nvim-lua/master
4e3de20 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
khsoh pushed a commit to khsoh/kickstart.nvim that referenced this pull request Sep 12, 2024
@Cheveniko
feat: update references of tsserver to ts_ls (nvim-lua#1131)
a46a161
angerborn pushed a commit to angerborn/kickstart.nvim that referenced this pull request Sep 12, 2024
@Cheveniko @angerborn
feat: update references of tsserver to ts_ls (nvim-lua#1131)
1ec5190
kpollich pushed a commit to kpollich/kickstart.nvim that referenced this pull request Sep 13, 2024
@Cheveniko @kpollich
feat: update references of tsserver to ts_ls (nvim-lua#1131)
6f7a3ca
gam-phon added a commit to gam-phon/kickstart.nvim that referenced this pull request Sep 13, 2024
@gam-phon
Merge pull request #3 from nvim-lua/master
b16f43e 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
distenz pushed a commit to distenz/nvim that referenced this pull request Sep 14, 2024
@Cheveniko @distenz
feat: update references of tsserver to ts_ls (nvim-lua#1131)
278355c
distenz added a commit to distenz/nvim that referenced this pull request Sep 14, 2024
@distenz
Merge pull request #2 from nvim-lua/master
4309dd5 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
antoningfors added a commit to antoningfors/nvim that referenced this pull request Sep 14, 2024
@antoningfors
Merge pull request #1 from nvim-lua/master
135918a 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
eng-alecrim pushed a commit to eng-alecrim/kickstart.nvim that referenced this pull request Sep 16, 2024
@Cheveniko @eng-alecrim
feat: update references of tsserver to ts_ls (nvim-lua#1131)
259939a
minhaz5000 added a commit to minhaz5000/kickstart.nvim that referenced this pull request Sep 16, 2024
@minhaz5000
Merge pull request #1 from nvim-lua/master
b797d5a 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
alextilot pushed a commit to alextilot/kickstart.nvim that referenced this pull request Sep 17, 2024
@Cheveniko @alextilot
feat: update references of tsserver to ts_ls (nvim-lua#1131)
ed08c81
BaconIsAVeg pushed a commit to BaconIsAVeg/kickstart-modular.nvim that referenced this pull request Sep 17, 2024
@jhoffmann
Merge remote-tracking branch 'upstream/master' into local
fa93fed 
* upstream/master:
  feat: update references of tsserver to ts_ls (nvim-lua#1131)
  Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)
  cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)
  fix: remove deprecated opt for conform.nvim (nvim-lua#1070)
  Fix: updated the windows installation commands (nvim-lua#1101)
  Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)
  Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)
  refactor: update treesitter and which-key config (nvim-lua#1068)
  Check for loop or uv for lazypath (nvim-lua#1095)
  Add note in README about lazy-lock.json (nvim-lua#1090)
  Update README.md (nvim-lua#1091)
mynever pushed a commit to mynever/kickstart.nvim that referenced this pull request Sep 20, 2024
@Cheveniko @mynever
feat: update references of tsserver to ts_ls (nvim-lua#1131)
24cb2e1
arjunomray pushed a commit to arjunomray/nvim that referenced this pull request Sep 21, 2024
@Cheveniko @arjunomray
feat: update references of tsserver to ts_ls (nvim-lua#1131)
ec880fd
bublebboy added a commit to bublebboy/kickstart.nvim that referenced this pull request Sep 22, 2024
@bublebboy
Merge pull request #1 from nvim-lua/master
7574242 
feat: update references of tsserver to ts_ls (nvim-lua#1131)
ge3224 pushed a commit to ge3224/nvimconf that referenced this pull request Sep 22, 2024
@Cheveniko @ge3224
feat: update references of tsserver to ts_ls (nvim-lua#1131)
7b42259
GuNz2435 added a commit to GuNz2435/kickstart.nvim that referenced this pull request Sep 24, 2024
@GuNz2435 @rdvm
@dam9000 @feoh @VlaDexa @GameFuzzy @EvanCarroll @sudo-tee @adoante @rmacklin @smiggiddy @PerMalmberg @folke @tjdevries @tjkuson @MZhuvka @mmirus @mrr11k @qgates @srdtrk @rivenirvana @igniscyan @iton0 @abeldekat @jstrot @theoboldalex @mattgallagher92 @mike-jl @bayramkzk @pantharshit007 @Cheveniko
Update fork (#1)
031284e 
* Arch, btw (nvim-lua#852)

* Arch, btw

* Add unzip

* Add unzip for Fedora and --needed arg for Arch

* Comment about nerd font selection. Fixes nvim-lua#853 (nvim-lua#854)

* Fix: nvim-lua#847 - add prefer_git to treesitter config (nvim-lua#856)

* Enable inlay hints for the supporting servers (nvim-lua#843)

* Move plugin examples from README to optional plugin files (nvim-lua#831)

* Move autopairs example from README to an optional plugin

* Move neo-tree example from README to an optional plugin

* Add gitsigns recommended keymaps as an optional plugin (nvim-lua#858)

* fix: restore Mason config timing for DAP startup (again) (nvim-lua#865)

* Update README.md (nvim-lua#860)

Attempted fix for nvim-lua#859, provide reasonable Debian install instructions -- comment on GitHub issue with refinement.

* Minor improvements of debian install instructions. Fixes nvim-lua#859 (nvim-lua#869)

* Add a commented out example of the classic complete keymaps. Fixes nvim-lua#866 (nvim-lua#868)

* Fix deprecation notice of inlay hints (nvim-lua#873)

* Fix highlight errors when lsp crash or stop (nvim-lua#864)

* Fix highlight errors when lsp crash or stop

It adds a check wether the client is still available before
highlighting.

If the client is not there anymore it returns `true` to unregister the
autocommand

This fix the
`method textDocument/documentHighlight is not supported by any of the servers registered for the current buffer`
errors when doing a LspRestart or the server crashes

* Delete the highlight autocommands in the LspDetatch event

* Only delete autocmds for the current buffer with the group name

* Simplify clearing the autocommands

---------

Co-authored-by: Francis Belanger <francis.belanger@ubisoft.com>

* fix: highlight group clear on each attach (nvim-lua#874)

* Update README.md (nvim-lua#875)

Line 102. Placed 'also' before the 'includes'.

"That includes also examples of adding popularly requested plugins." ---> "That also includes examples of adding popularly requested plugins."

* README: add clipboard tool dependency (nvim-lua#886)

Fixes: nvim-lua#884
Neovim requires an external tool for proper system clipboard integration.
Some systems install this already by default:
- on Fedora xsel is already installed by default
- on Windows using the choko install the win32yank is alredy installed
This is not installed by default on ubuntu or debian so adding that
to the dependencies list and to the install instructions snippets.

* Move LspDetach handler near kickstart-lsp-highlight group (nvim-lua#900)

Moved to make sure the kickstart-lsp-highlight group exists when
the LspDetach handler is invoked. The LspDetach handler is used
to clean up any lsp highlights that were enabled by CursorHold
if the LSP is stopped or crashed.

* Add diff to treesitter's ensure_installed languages (nvim-lua#908)

* fix: debug.lua (nvim-lua#918)

* Automatically set detached state as needed. (nvim-lua#925)

* Automatically set detached state as needed.

* Use vim.fn.has instead.

* Fix int vs bool.

* which-key v3 update (nvim-lua#1022)

* which-key v3 update

* remove unneeded brackets from which-key registration

* fix(lazy): added error handling for bootstrap (nvim-lua#1001)

* fix: add required parsers from nvim-treesitter

* Fix neo-tree keymap description (nvim-lua#932)

The lazy.nvim keys parameter does not need the `desc` to
be inside a table in the way that vim.keymap.set() does.
With this fix the keymap description will be properly
shown for example in telescope keymap search

* Remove redundant require (nvim-lua#959)

* Make debug lazy loadable (nvim-lua#978)

* Update README.md | %userprofile%\appdata\local -> %localappdata% (nvim-lua#963)

- Replace `%userprofile%\AppData\Local\nvim\` and `$env:USERPROFILE\AppData\Local\nvim` to `%localappdata%\nvim` and `$env:LOCALAPPDATA\nvim respectfully`

* Make conform.nvim be lazy-loadable again (nvim-lua#977)

The PR that disabled lazy loading (nvim-lua#818) was to fix plugin not being
loaded before write. This sets up lazy to load conform before write.

* Fix comment about mini.ai example (nvim-lua#985)

This example wasn't using `'` so this makes more sense

* Neovim 0.10 updates (nvim-lua#936)

* Neovim 0.10 updates

Provide the buffer for which to enable inlay hints

Co-authored-by: Matt Mirus <matt@mattmirus.com>

* refactor: replace vim.loop with vim.uv

* Upgrade folke/neodev (sunsetting) to folke/lazydev

* Update checkhealth for 0.10 release

---------

Co-authored-by: Matt Mirus <matt@mattmirus.com>
Co-authored-by: mrr11k <me+github@mrr11k.dev>
Co-authored-by: Seb Tomasini <sebt@qgates.com>

* Update lazydev config to fix "Undefined field `fs_stat`" LSP error (nvim-lua#1040)

7513ec8 switched from neodev to
lazydev, but in the process it introduced an LSP error in `init.lua`,
which degrades the desired "first timer" experience of kickstart.nvim.

This commit follows the configuration suggested in
https://github.com/folke/lazydev.nvim/tree/6184ebbbc8045d70077659b7d30c705a588dc62f#-installation
which resolves the LSP error.

* lint: fix lsp warning in `vim.lsp.inlay_hint.is_enabled` (nvim-lua#947)

* fix: lsp warning

* review suggestion

Co-authored-by: Tom Kuson <mail@tjkuson.me>

---------

Co-authored-by: Tom Kuson <mail@tjkuson.me>

* Update comment about the toggle inlay hints keymap (nvim-lua#1041)

* Remove redundant hlsearch option (nvim-lua#1058)

* Modify conform comments to prevent deprecation warning when used (nvim-lua#1057)

* refactor: remove lazydev and luvit-meta as lsp dependencies (nvim-lua#1047)

* performance: defer clipboard because xsel and pbcopy can be slow (nvim-lua#1049)

* Remove treesitter prefer_git option (nvim-lua#1061)

- It's not safe and can corrupt other git repos
- nvim-treesiter maintainers consider `prefer_git` as deprecated and no
  longer needed.

See nvim-treesitter PR for details: nvim-treesitter/nvim-treesitter#6959

* Add explicit dependency of nvim-lspconfig on cmp-nvim-lsp (nvim-lua#1042)

* Update README.md (nvim-lua#1091)

* Add note in README about lazy-lock.json (nvim-lua#1090)

* Check for loop or uv for lazypath (nvim-lua#1095)

* refactor: update treesitter and which-key config (nvim-lua#1068)

* Include visual mode in LSP code action keymap (nvim-lua#1060) (nvim-lua#1064)

* Enable silent option for default neo-tree plugin keybinding (nvim-lua#1108)

* Fix: updated the windows installation commands (nvim-lua#1101)

* Update README.md

* Update README.md

* Fix: updated the windows installation commands

* fix: remove deprecated opt for conform.nvim (nvim-lua#1070)

- changed lsp_fallback -> lsp_format
- updated format_on_save function to reflect change above

* cleanup: refactor which-key configuration for cleaner setup (nvim-lua#1102)

- Moved `which-key` configuration from inline `config` to `opts` for better organization.
- Updated the key mappings setup to use `spec` for defining existing key chains.
- Removed deprecated or unnecessary comments and code.

This change aligns with updated `which-key` configuration practices, improving readability and maintainability as recommended by @VlaDexa in nvim-lua#1068.

* Fix the which-key spec issue caused by recent cleanup (nvim-lua#1113)

The recent cleanup accidentally broke the leader key specs
because the spec block was in the wrong level of braces.
That resulted in which-key no longer showing the description
of the <leader> key chains such as [S]earch and others.

* feat: update references of tsserver to ts_ls (nvim-lua#1131)

---------

Co-authored-by: rdvm <git@rvm.dev>
Co-authored-by: Damjan 9000 <damjan.9000@gmail.com>
Co-authored-by: Chris Patti <feoh@feoh.org>
Co-authored-by: Vladislav Grechannik <52157081+VlaDexa@users.noreply.github.com>
Co-authored-by: GameFuzzy <mail@gamefuzzy.dev>
Co-authored-by: Evan Carroll <me@evancarroll.com>
Co-authored-by: Francis Belanger <francis.belanger@gmail.com>
Co-authored-by: Francis Belanger <francis.belanger@ubisoft.com>
Co-authored-by: Adolfo Gante <adolfogante@gmail.com>
Co-authored-by: Richard Macklin <1863540+rmacklin@users.noreply.github.com>
Co-authored-by: Smig <89040888+smiggiddy@users.noreply.github.com>
Co-authored-by: Per Malmberg <PerMalmberg@users.noreply.github.com>
Co-authored-by: Folke Lemaitre <folke.lemaitre@gmail.com>
Co-authored-by: TJ DeVries <devries.timothyj@gmail.com>
Co-authored-by: Tom Kuson <mail@tjkuson.me>
Co-authored-by: Artyom <84637383+MZhuvka@users.noreply.github.com>
Co-authored-by: Matt Mirus <matt@mattmirus.com>
Co-authored-by: mrr11k <me+github@mrr11k.dev>
Co-authored-by: Seb Tomasini <sebt@qgates.com>
Co-authored-by: srdtrk <59252793+srdtrk@users.noreply.github.com>
Co-authored-by: Arvin Verain <arvinverain@proton.me>
Co-authored-by: Brandon Clark <bwclark97@gmail.com>
Co-authored-by: Ihsan Tonuzi <115842560+iton0@users.noreply.github.com>
Co-authored-by: abeldekat <58370433+abeldekat@users.noreply.github.com>
Co-authored-by: jstrot <44594069+jstrot@users.noreply.github.com>
Co-authored-by: theoboldalex <44616505+theoboldalex@users.noreply.github.com>
Co-authored-by: Matt Gallagher <46973220+mattgallagher92@users.noreply.github.com>
Co-authored-by: Michael L. <m@lehenauer.com>
Co-authored-by: Bayram Kazik <48856944+bayramkzk@users.noreply.github.com>
Co-authored-by: Harshit Pant <97608579+pantharshit007@users.noreply.github.com>
Co-authored-by: Nicolás Baquero <88566759+Cheveniko@users.noreply.github.com>
DougAnTr pushed a commit to DougAnTr/nvim that referenced this pull request Sep 26, 2024
@Cheveniko @DougAnTr
feat: update references of tsserver to ts_ls (nvim-lua#1131)
2b4b703
abenteuerzeit pushed a commit to abenteuerzeit/kickstart.nvim that referenced this pull request Sep 27, 2024
@Cheveniko @abenteuerzeit
feat: update references of tsserver to ts_ls (nvim-lua#1131)
60bca89
Lumonde-software pushed a commit to Lumonde-software/kickstart.nvim that referenced this pull request Sep 29, 2024
@Cheveniko @Lumonde-software
feat: update references of tsserver to ts_ls (nvim-lua#1131)
4e9f1e2
restray pushed a commit to restray/kickstart.nvim that referenced this pull request Sep 30, 2024
@Cheveniko
feat: update references of tsserver to ts_ls (nvim-lua#1131)
6a240b8
diegorodriguezv pushed a commit to diegorodriguezv/kickstart.nvim that referenced this pull request Oct 1, 2024
@Cheveniko @diegorodriguezv
feat: update references of tsserver to ts_ls (nvim-lua#1131)
503bd9c
umairraza96 pushed a commit to umairraza96/kickstart.nvim that referenced this pull request Oct 5, 2024
@Cheveniko @umairraza96
feat: update references of tsserver to ts_ls (nvim-lua#1131)
e7d047a
resist15 added a commit to resist15/kickstart.nvim that referenced this pull request Oct 7, 2024
@resist15
Merge https://github.com/nvim-lua/kickstart.nvim
56cd259 
* https://github.com/nvim-lua/kickstart.nvim:
  fix: update lazy uninstall information link (nvim-lua#1148)
  feat: update references of tsserver to ts_ls (nvim-lua#1131)

Change-Id: I4ed316d2d157e5f7e8296673d093be5ce9a77359
ditatompel added a commit to ditatompel/ditatompel that referenced this pull request Oct 7, 2024
@ditatompel
feat: update references of tsserver to ts_ls (nvim-lua/kickstart.nvim…
8ad3ab7 
…#1131)
hchienjo pushed a commit to hchienjo/kickstart.nvim that referenced this pull request Oct 19, 2024
@Cheveniko @hchienjo
feat: update references of tsserver to ts_ls (nvim-lua#1131)
41a9f63
frankstutz pushed a commit to frankstutz/kickstart.nvim that referenced this pull request Oct 24, 2024
@Cheveniko @frankstutz
feat: update references of tsserver to ts_ls (nvim-lua#1131)
8abb5cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BraedenKilburn BraedenKilburn BraedenKilburn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Cheveniko @shivambegin @samarth-na @BraedenKilburn @feoh