feat: move to lazy and fix many issues #178
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,3 +3,4 @@ test.sh | |
| .luarc.json | ||
| nvim | ||
| plugin/packer_compiled.lua | ||
| lazy-lock.json | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| return { | ||
| 'neovim/nvim-lspconfig', | ||
|
There was a problem hiding this comment. TODO: For myself, could add null-ls here since I know that's a big hang up for a lot of people There was a problem hiding this comment. meh, i think i'll do this later if I want it |
||
|
|
||
| config = function() | ||
| -- Switch for controlling whether you want autoformatting. | ||
| -- Use :KickstartFormatToggle to toggle autoformatting on or off | ||
| local format_is_enabled = true | ||
| vim.api.nvim_create_user_command('KickstartFormatToggle', function() | ||
| format_is_enabled = not format_is_enabled | ||
| print('Setting autoformatting to: ' .. tostring(format_is_enabled)) | ||
| end, {}) | ||
|
|
||
| -- Create an augroup that is used for managing our formatting autocmds. | ||
| -- We need one augroup per client to make sure that multiple clients | ||
| -- can attach to the same buffer without interfering with each other. | ||
| local _augroups = {} | ||
| local get_augroup = function(client) | ||
| if not _augroups[client.id] then | ||
| local group_name = 'kickstart-lsp-format-' .. client.name | ||
| local id = vim.api.nvim_create_augroup(group_name, { clear = true }) | ||
| _augroups[client.id] = id | ||
| end | ||
|
|
||
| return _augroups[client.id] | ||
| end | ||
|
|
||
| vim.api.nvim_create_autocmd('LspAttach', { | ||
| group = vim.api.nvim_create_augroup('kickstart-lsp-attach-format', { clear = true }), | ||
|
|
||
| -- This is where we attach the autoformatting for reasonable clients | ||
| callback = function(args) | ||
| local client_id = args.data.client_id | ||
| local client = vim.lsp.get_client_by_id(client_id) | ||
| local bufnr = args.buf | ||
|
|
||
| -- Only attach to clients that support document formatting | ||
| if not client.server_capabilities.documentFormattingProvider then | ||
| return | ||
| end | ||
|
|
||
| -- Tsserver usually works poorly. Sorry you work with bad languages | ||
| -- You can remove this line if you know what you're doing :) | ||
| if client.name == 'tsserver' then | ||
| return | ||
| end | ||
|
|
||
| vim.api.nvim_create_autocmd('BufWritePre', { | ||
| group = get_augroup(client), | ||
| buffer = bufnr, | ||
| callback = function() | ||
| if not format_is_enabled then | ||
| return | ||
| end | ||
|
|
||
| vim.lsp.buf.format { async = false } | ||
| end, | ||
| }) | ||
| end, | ||
| }) | ||
| end, | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| return { | ||
| { | ||
| enabled = true, | ||
| config = function() | ||
| -- Optional debug adapter setup | ||
| -- | ||
| -- To enable setup, change `disable = true` in the packer section | ||
|
There was a problem hiding this comment. Guessing you'll want to update 'in the packer section' to something lazy.nvim specific? There was a problem hiding this comment. yeah, i will make it so the debug config works with lazy -- this was leftover from an old PR that I never submitted |
||
| -- of the init.lua. You'll also want to copy this file into your | ||
| -- config at ~/.config/nvim/after/plugin/dap.lua | ||
|
|
||
| local dapui = require 'dapui' | ||
|
|
||
| require('mason-nvim-dap').setup { | ||
| -- Makes a best effort to setup the various debuggers with | ||
| -- reasonable debug configurations | ||
| automatic_setup = true, | ||
|
|
||
| -- You'll need to check that you have the required things installed | ||
| -- online, please don't ask me how to install them :) | ||
| ensure_installed = { | ||
| -- Update this to ensure that you have the debuggers for the langs you want | ||
| 'delve', | ||
| }, | ||
| } | ||
|
|
||
| -- You can provide additional configuration to the handlers, | ||
| -- see mason-nvim-dap README for more information | ||
| require('mason-nvim-dap').setup_handlers() | ||
|
|
||
| -- Basic debugging keymaps, feel free to change to your liking! | ||
| vim.keymap.set('n', '<F5>', require('dap').continue) | ||
| vim.keymap.set('n', '<F1>', require('dap').step_into) | ||
| vim.keymap.set('n', '<F2>', require('dap').step_over) | ||
| vim.keymap.set('n', '<F3>', require('dap').step_out) | ||
| vim.keymap.set('n', '<leader>b', require('dap').toggle_breakpoint) | ||
| vim.keymap.set('n', '<leader>B', function() | ||
| require('dap').set_breakpoint(vim.fn.input 'Breakpoint condition: ') | ||
| end) | ||
|
|
||
| -- Dap UI setup | ||
| -- For more information, see |:help nvim-dap-ui| | ||
| dapui.setup { | ||
| -- Set icons to characters that are more likely to work in every terminal. | ||
| -- Feel free to remove or use ones that you like more! :) | ||
| -- Don't feel like these are good choices. | ||
| icons = { expanded = '▾', collapsed = '▸', current_frame = '*' }, | ||
| controls = { | ||
| icons = { | ||
| pause = '⏸', | ||
| play = '▶', | ||
| step_into = '⏎', | ||
| step_over = '⏭', | ||
| step_out = '⏮', | ||
| step_back = 'b', | ||
| run_last = '▶▶', | ||
| terminate = '⏹', | ||
| }, | ||
| }, | ||
| } | ||
|
|
||
| dap.listeners.after.event_initialized['dapui_config'] = dapui.open | ||
| dap.listeners.before.event_terminated['dapui_config'] = dapui.close | ||
| dap.listeners.before.event_exited['dapui_config'] = dapui.close | ||
|
|
||
| -- Install golang specific config | ||
| require('dap-go').setup() | ||
|
There was a problem hiding this comment. Pardon my ignorance, but will it be clear to folks where they should add the require().setup() for their own favorite languages? There was a problem hiding this comment. well you'll have to emulate what I've done here for golang -- i can list a few examples and the wiki entries to explore. I haven't done a bunch of DAP stuff for other languages There was a problem hiding this comment. if you add mason-nvim-dap and the following in your config for nvim-dap, then you can just install daps from mason, and they work out of the box. A very GUI-way of doing things, but for beginners its really cool. you would not need to configure anything in init.lua There was a problem hiding this comment. here is my full call to nvim-dap with packer, for clarification: There was a problem hiding this comment. Right, but some of the plugins give you additional configuration that allow you to do different types of debugging (like attaching to running process, run individual unit tests, etc) There was a problem hiding this comment. This is something I've struggled with and hope to contribute back to help other newbies :) Specifically, I find it tremendously confusing to understand how to express the configuration for any given plugin, and I think the root of the confusion is understaning what lua lexical/function closure/scope a given plugin wants for its configuration. Take this for example - it took me forever to understand that wrapping all my extra 'use' directives in a Is there a way to signpost this for new users? Will Lazy make this easier? Thanks so much for all your hard work. kickstart.nvim & neovim have made me a more productive developer == PRICELESS :) There was a problem hiding this comment. yes, the new method is much simpler and less error prone. I will add docs as well before I merge |
||
| end, | ||
| }, | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for the awesome setup, this is awesome for the community!
I think the lazy-lock should probably be committed to maintain versions across multiple machines?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I want to commit mine. Users can commit their own though by modifying the gitignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tjdevries I have the same problem for LazyVim. I don't add the lockfile to .gitignore and simply never add mine to the repo. This way for users, they won't forget to add the lockfile to git.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm just thinking contributors and others will end up adding it on accident constantly haha