Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make init.lua copy-paste friendly #358

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Conversation

kdheepak
Copy link
Contributor

@kdheepak kdheepak commented Jul 1, 2023

Currently if you copy paste init.lua it gives an error because it tries to require "custom.plugins". If we want the copy paste path to be a happy path, I believe this should be commented by default.

@mech-a
Copy link
Contributor

mech-a commented Jul 1, 2023

We explicitly don't want people to copy and paste init.lua in -- that installation method is for a very outdated version of kickstart.

@kdheepak
Copy link
Contributor Author

kdheepak commented Jul 1, 2023

While I generally agree that copy paste isn’t the way to do things, I do believe in this case it is a small tradeoff for getting a happy path for the copy paste use case, e.g. if I wanted to demo how easy it is to start using nvim.

Also the readme mentions that this repo is a single file configuration with examples to move to a multiple file configuration. I believe this PR will make the readme more accurate to that sentiment.

@mech-a
Copy link
Contributor

mech-a commented Jul 1, 2023

Thanks for your comment - I agree that the PR brings us more in line with what we state on the readme. I think this is a good change and we won't need to adjust our installation instructions. @feoh I'm curious about your thoughts?

@feoh feoh merged commit 55aa0ea into nvim-lua:master Jul 7, 2023
qiuye2015 pushed a commit to qiuye2015/fjp.nvim that referenced this pull request Dec 10, 2023
Make init.lua copy-paste friendly
@kdheepak kdheepak deleted the patch-2 branch February 21, 2024 14:02
s-frick pushed a commit to s-frick/kickstart.nvim that referenced this pull request Jul 29, 2024
Make init.lua copy-paste friendly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants