Use telescope for goto implementation

[e-aakash]

Current key binding for goto implementation uses the default lsp functionality, which opens the list of implementations in new buffer.

Since the number of implementations is usually more than 1, using telescope.builtin.lsp_implementation is better since it shows the result in a dialog box and also shows preview.

[feoh]

Hi!

I really like this idea! Could you please add detailed instructions for testing this to the PR?

Like, if I pull this change into my fork and run Neovim, what do I need to do to test your change? What configuration assumptions does the change make that might not be suared by all users?

Thanks for the contribution. Looking forward to working with you to get this merged.

[feoh]

Gotta say, I know this was a typo, we all make them, and I don't want to beat up on anyone for making a contribution, but - how did you test this? I copied your change locally and was wondering why nothing was happening :)

[e-aakash]

Hi, sorry for delay in reply.

Like, if I pull this change into my fork and run Neovim, what do I need to do to test your change? What configuration assumptions does the change make that might not be suared by all users?

The assumption is user is working on language which is multiple implementation for a thing (like java interfaces) and has the corresponding lsp installed.

Previous behaviour: on pressing gI a buffer is opened listing implementaiotns
New behaviour: on pressing gI, telescope popup/floating window opens with implementations, along with preview

how did you test this

I was working two different machines, and made this pull request by manually typing the change, thinking it was small. I should have tested it again in the primary machine (forgot to test in the excitement of raising PR). Thanks for the comment and quick fix. I will keep in mind to test before raising pull request.

[feoh]

Yes please. Let me know when this is thoroughly tested and ready for inclusion.

[feoh]

@e-aakash Are you still interested in getting this PR merged or should I close it?

If I don't hear from you in a week or two I'll do that. I know what it's like to get busy :)

[feoh]

OK I tested this a bunch and read the documentation for telescope.builtin.lsp_implementation.

This makes sense to me and it seems to work so I'm going to merge it.

If anyone has feelings about this, we can always revert.