Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation on how to set up friendly-snippets #709

Closed
wants to merge 1 commit into from
Closed

add documentation on how to set up friendly-snippets #709

wants to merge 1 commit into from

Conversation

sqrtnull
Copy link

@sqrtnull sqrtnull commented Mar 5, 2024

Added documentation to clarify #680

@sqrtnull
Copy link
Author

sqrtnull commented Mar 5, 2024

I am unsure whether it would be better to just outright enable vscode-style snippets for LuaSnip so people would not encounter this problem, since a comment telling you to insert code somewhere else seems weird (to me).

@feoh
Copy link
Collaborator

feoh commented Mar 12, 2024

Hi.

This would need substantial rework in order to be useful. Also I'm not sure that providing 1000% VSCode compat is the goal of this project.

In particular, should you choose to re-open and pursue this, you'd need explicit instructions as to where to put what so as to be more friendly for newer folks which is the target audience of this project.

Thank you for your contribution but I'm closing for now.

@feoh feoh closed this Mar 12, 2024
@sqrtnull
Copy link
Author

@feoh I am not sure what you are getting at here; the friendly-snippets plugin requires LuaSnip to accept vscode-style snippets for it to work properly, thus the comment/suggestion. That being said, I agree with you in that this commit itself is not the way to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants